linux-kernel - Re: [PATCH v2 2/2] perf vendor events arm64 AmpereOne: Fix typos in metrics' descriptions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fc2ee38c-b163-4b7e-9ba2-c2b93d0fc691@linaro.org>
Date: Thu, 11 Sep 2025 09:26:47 +0100
From: James Clark <james.clark@...aro.org>
To: Ilkka Koskinen <ilkka@...amperecomputing.com>
Cc: linux-arm-kernel@...ts.infradead.org, linux-perf-users@...r.kernel.org,
 linux-kernel@...r.kernel.org, John Garry <john.g.garry@...cle.com>,
 Will Deacon <will@...nel.org>, Mike Leach <mike.leach@...aro.org>,
 Leo Yan <leo.yan@...ux.dev>, Peter Zijlstra <peterz@...radead.org>,
 Ingo Molnar <mingo@...hat.com>, Arnaldo Carvalho de Melo <acme@...nel.org>,
 Namhyung Kim <namhyung@...nel.org>, Mark Rutland <mark.rutland@....com>,
 Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
 Jiri Olsa <jolsa@...nel.org>, Ian Rogers <irogers@...gle.com>,
 Adrian Hunter <adrian.hunter@...el.com>,
 "Liang, Kan" <kan.liang@...ux.intel.com>
Subject: Re: [PATCH v2 2/2] perf vendor events arm64 AmpereOne: Fix typos in
 metrics' descriptions



On 10/09/2025 8:52 pm, Ilkka Koskinen wrote:
> While fixing a typo in "l1d_cache_access_prefetches" in AmpereOneX,
> a few other typos were found in metrics' descriptions too. While AmpereOne
> doesn't have the metric, it did have the typos in the descriptions.
> 
> Signed-off-by: Ilkka Koskinen <ilkka@...amperecomputing.com>
> ---
>   .../pmu-events/arch/arm64/ampere/ampereone/metrics.json   | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/tools/perf/pmu-events/arch/arm64/ampere/ampereone/metrics.json b/tools/perf/pmu-events/arch/arm64/ampere/ampereone/metrics.json
> index afcdad58ef89..324104438e78 100644
> --- a/tools/perf/pmu-events/arch/arm64/ampere/ampereone/metrics.json
> +++ b/tools/perf/pmu-events/arch/arm64/ampere/ampereone/metrics.json
> @@ -113,7 +113,7 @@
>       {
>   	"MetricName": "load_store_spec_rate",
>   	"MetricExpr": "((LDST_SPEC / INST_SPEC) * 100)",
> -	"BriefDescription": "The rate of load or store instructions speculatively executed to overall instructions speclatively executed",
> +	"BriefDescription": "The rate of load or store instructions speculatively executed to overall instructions speculatively executed",
>           "MetricGroup": "Operation_Mix",
>           "ScaleUnit": "1percent of operations"
>       },
> @@ -132,7 +132,7 @@
>       {
>   	"MetricName": "pc_write_spec_rate",
>   	"MetricExpr": "((PC_WRITE_SPEC / INST_SPEC) * 100)",
> -	"BriefDescription": "The rate of software change of the PC speculatively executed to overall instructions speclatively executed",
> +	"BriefDescription": "The rate of software change of the PC speculatively executed to overall instructions speculatively executed",
>           "MetricGroup": "Operation_Mix",
>           "ScaleUnit": "1percent of operations"
>       },
> @@ -195,14 +195,14 @@
>       {
>   	"MetricName": "stall_frontend_cache_rate",
>   	"MetricExpr": "((STALL_FRONTEND_CACHE / CPU_CYCLES) * 100)",
> -	"BriefDescription": "Proportion of cycles stalled and no ops delivered from frontend and cache miss",
> +	"BriefDescription": "Proportion of cycles stalled and no operations delivered from frontend and cache miss",
>   	"MetricGroup": "Stall",
>           "ScaleUnit": "1percent of cycles"
>       },
>       {
>   	"MetricName": "stall_frontend_tlb_rate",
>   	"MetricExpr": "((STALL_FRONTEND_TLB / CPU_CYCLES) * 100)",
> -	"BriefDescription": "Proportion of cycles stalled and no ops delivered from frontend and TLB miss",
> +	"BriefDescription": "Proportion of cycles stalled and no operations delivered from frontend and TLB miss",
>   	"MetricGroup": "Stall",
>           "ScaleUnit": "1percent of cycles"
>       },

Reviewed-by: James Clark <james.clark@...aro.org>