[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <52b72e63-9aa6-401f-8d7e-397fe0c89dca@fairphone.com>
Date: Thu, 11 Sep 2025 11:03:49 +0200
From: Griffin Kroah-Hartman <griffin.kroah@...rphone.com>
To: Dmitry Torokhov <dmitry.torokhov@...il.com>, Rob Herring
<robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>, Bjorn Andersson <andersson@...nel.org>,
Konrad Dybcio <konradybcio@...nel.org>, Luca Weiss <luca.weiss@...rphone.com>
Cc: linux-input@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org,
Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
Konrad Dybcio <konrad.dybcio@....qualcomm.com>
Subject: Re: [PATCH v3 0/3] Add support for Awinic AW86927 haptic driver
On 8/14/25 16:31, Griffin Kroah-Hartman wrote:
> Add devicetree bindings and a driver for the AW86927 haptic driver, and
> add it to the devicetree for the Fairphone 5 smartphone.
>
> This driver does not enable all capabilities of the AW86927, features
> such as f0 detection, rtp mode, and cont mode are not included.
>
> Note: This is my first driver I have ever worked on so if there is
> anything I can do to improve it please let me know!
>
> Signed-off-by: Griffin Kroah-Hartman <griffin.kroah@...rphone.com>
> ---
> Changes in v3:
> - Removed obsolete FIXME comments
> - Adjusted Error handling to fit best practice
> - Changed formatting due to feedback
> - Removed obsolete terminology from patch subjects.
> - Properly credited reviewers
> - Link to v2: https://lore.kernel.org/r/20250811-aw86927-v2-0-64be8f3da560@fairphone.com
>
> Changes in v2:
> - Changed title and fixed license of devicetree binding
> - Fixed typo where the 'm' in 'ms' was excluded
> - Changed error handling return values in driver probe function
> - Link to v1: https://lore.kernel.org/r/20250806-aw86927-v1-0-23d8a6d0f2b2@fairphone.com
>
> ---
> Griffin Kroah-Hartman (3):
> dt-bindings: input: Add Awinic AW86927
> Input: aw86927 - add driver for Awinic AW86927
> arm64: dts: qcom: qcm6490-fairphone-fp5: Add vibrator support
>
> .../devicetree/bindings/input/awinic,aw86927.yaml | 48 ++
> arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts | 18 +-
> drivers/input/misc/Kconfig | 11 +
> drivers/input/misc/Makefile | 1 +
> drivers/input/misc/aw86927.c | 854 +++++++++++++++++++++
> 5 files changed, 931 insertions(+), 1 deletion(-)
> ---
> base-commit: 3624e9a34b36d64a7037946eda28ae9599363a3b
> change-id: 20250804-aw86927-9dddc32fcaec
>
> Best regards,
Hi Dmitry, did you get a chance to look at this patch series yet?
Thanks,
Griffin
Powered by blists - more mailing lists