| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <20250911-csi-bgr-rgb-v2-4-e6c6b10c1040@kernel.org>
Date: Thu, 11 Sep 2025 11:15:35 +0200
From: Maxime Ripard <mripard@...nel.org>
To: Mauro Carvalho Chehab <mchehab@...nel.org>,
Mats Randgaard <matrandg@...co.com>,
Alain Volmat <alain.volmat@...s.st.com>,
Sakari Ailus <sakari.ailus@...ux.intel.com>,
Hans Verkuil <hverkuil@...nel.org>
Cc: linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
Hans Verkuil <hans.verkuil@...co.com>,
Dave Stevenson <dave.stevenson@...pberrypi.com>,
Maxime Ripard <mripard@...nel.org>
Subject: [PATCH v2 4/4] media: gc2145: Fix the RGB MBUS format
The GalaxyCore GC2145 is an MIPI-CSI2 sensor. Among others, it support
the MIPI-CSI2 RGB565 format, listed in the driver as
MEDIA_BUS_FMT_RGB565_1X16.
Most CSI2 receiver drivers then map MEDIA_BUS_FMT_RGB565_1X16 to
V4L2_PIX_FMT_RGB565.
However, V4L2_PIX_FMT_RGB565 is defined as having its color components
in the R, G and B order, from left to right. MIPI-CSI2 however defines
the RGB565 format with blue first.
This essentially means that the R and B will be swapped compared to what
V4L2_PIX_FMT_RGB565 defines.
The proper MBUS format would be BGR565, so let's use that.
Fixes: 03cc7fefbb09 ("media: i2c: gc2145: Galaxy Core GC2145 sensor support")
Signed-off-by: Maxime Ripard <mripard@...nel.org>
---
drivers/media/i2c/gc2145.c | 23 +++++++++++++++++++++--
1 file changed, 21 insertions(+), 2 deletions(-)
diff --git a/drivers/media/i2c/gc2145.c b/drivers/media/i2c/gc2145.c
index 559a851669aaf57cfba4d8834d04de9a3e3d91e0..59a0e51c70c84fe1045701d246d02bb1cf97388c 100644
--- a/drivers/media/i2c/gc2145.c
+++ b/drivers/media/i2c/gc2145.c
@@ -579,11 +579,11 @@ static const struct gc2145_format supported_formats[] = {
.colorspace = V4L2_COLORSPACE_SRGB,
.datatype = MIPI_CSI2_DT_YUV422_8B,
.output_fmt = 0x03,
},
{
- .code = MEDIA_BUS_FMT_RGB565_1X16,
+ .code = MEDIA_BUS_FMT_BGR565_1X16,
.colorspace = V4L2_COLORSPACE_SRGB,
.datatype = MIPI_CSI2_DT_RGB565,
.output_fmt = 0x06,
.switch_bit = true,
},
@@ -613,10 +613,25 @@ static const struct gc2145_format supported_formats[] = {
.colorspace = V4L2_COLORSPACE_RAW,
.datatype = MIPI_CSI2_DT_RAW8,
.output_fmt = 0x17,
.row_col_switch = GC2145_SYNC_MODE_ROW_SWITCH,
},
+ {
+ /*
+ * The driver was initially introduced with RGB565 support, but
+ * CSI really means BGR.
+ *
+ * Since we might have applications that would have hard-coded
+ * the RGB565, let's support both, with RGB being last to make
+ * sure it's only a last resort.
+ */
+ .code = MEDIA_BUS_FMT_RGB565_1X16,
+ .colorspace = V4L2_COLORSPACE_SRGB,
+ .datatype = MIPI_CSI2_DT_RGB565,
+ .output_fmt = 0x06,
+ .switch_bit = true,
+ },
};
struct gc2145_ctrls {
struct v4l2_ctrl_handler handler;
struct v4l2_ctrl *pixel_rate;
@@ -660,10 +675,14 @@ static inline struct v4l2_subdev *gc2145_ctrl_to_sd(struct v4l2_ctrl *ctrl)
static const struct gc2145_format *
gc2145_get_format_code(struct gc2145 *gc2145, u32 code)
{
unsigned int i;
+ if (code == MEDIA_BUS_FMT_RGB565_1X16)
+ v4l2_warn(&gc2145->sd,
+ "RGB format isn't actually supported by the hardware. The application should be fixed to use BGR.");
+
for (i = 0; i < ARRAY_SIZE(supported_formats); i++) {
if (supported_formats[i].code == code)
break;
}
@@ -696,11 +715,11 @@ static int gc2145_init_state(struct v4l2_subdev *sd,
struct v4l2_rect *crop;
/* Initialize pad format */
format = v4l2_subdev_state_get_format(state, 0);
gc2145_update_pad_format(gc2145, &supported_modes[0], format,
- MEDIA_BUS_FMT_RGB565_1X16,
+ MEDIA_BUS_FMT_BGR565_1X16,
V4L2_COLORSPACE_SRGB);
/* Initialize crop rectangle. */
crop = v4l2_subdev_state_get_crop(state, 0);
*crop = supported_modes[0].crop;
--
2.50.1
Powered by blists - more mailing lists