linux-kernel - Re: [PATCH v3 1/3] coresight: tmc: Add missing doc including reading and etr_mode of struct tmc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250911093807.GE12516@e132581.arm.com>
Date: Thu, 11 Sep 2025 10:38:07 +0100
From: Leo Yan <leo.yan@....com>
To: Junhao He <hejunhao3@...wei.com>
Cc: suzuki.poulose@....com, james.clark@....com, anshuman.khandual@....com,
	coresight@...ts.linaro.org, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org, linuxarm@...wei.com,
	jonathan.cameron@...wei.com, yangyicong@...wei.com,
	prime.zeng@...ilicon.com
Subject: Re: [PATCH v3 1/3] coresight: tmc: Add missing doc including reading
 and etr_mode of struct tmc_drvdata

On Mon, Aug 18, 2025 at 04:05:58PM +0800, Junhao He wrote:
> From: Yicong Yang <yangyicong@...ilicon.com>
> 
> tmc_drvdata::reading is used to indicate whether a reading process
> is performed through /dev/xyz.tmc.
> tmc_drvdata::etr_mode is used to store the Coresight TMC-ETR buffer
> mode selected by the user.
> Document them.
> 
> Reviewed-by: James Clark <james.clark@...aro.org>
> Signed-off-by: Yicong Yang <yangyicong@...ilicon.com>
> Signed-off-by: Junhao He <hejunhao3@...wei.com>

Reviewed-by: Leo Yan <leo.yan@....com>

> ---
>  drivers/hwtracing/coresight/coresight-tmc.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/hwtracing/coresight/coresight-tmc.h b/drivers/hwtracing/coresight/coresight-tmc.h
> index 6541a27a018e..9daa2680cfb6 100644
> --- a/drivers/hwtracing/coresight/coresight-tmc.h
> +++ b/drivers/hwtracing/coresight/coresight-tmc.h
> @@ -220,6 +220,7 @@ struct tmc_resrv_buf {
>   * @pid:	Process ID of the process that owns the session that is using
>   *		this component. For example this would be the pid of the Perf
>   *		process.
> + * @reading:	buffer's in the reading through "/dev/xyz.tmc" entry
>   * @stop_on_flush: Stop on flush trigger user configuration.
>   * @buf:	Snapshot of the trace data for ETF/ETB.
>   * @etr_buf:	details of buffer used in TMC-ETR
> @@ -232,6 +233,7 @@ struct tmc_resrv_buf {
>   * @trigger_cntr: amount of words to store after a trigger.
>   * @etr_caps:	Bitmask of capabilities of the TMC ETR, inferred from the
>   *		device configuration register (DEVID)
> + * @etr_mode:	User preferred mode of the ETR device, default auto mode.
>   * @idr:	Holds etr_bufs allocated for this ETR.
>   * @idr_mutex:	Access serialisation for idr.
>   * @sysfs_buf:	SYSFS buffer for ETR.
> -- 
> 2.33.0
>