linux-kernel - Re: [PATCH RESEND] sched/fair: Only increment deadline once on yield

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b988336c-86a3-41b9-9711-7fe215ff66c7@amazon.com>
Date: Thu, 11 Sep 2025 13:03:07 +0200
From: Alexander Graf <graf@...zon.com>
To: Fernand Sieber <sieberf@...zon.com>, <mingo@...hat.com>,
	<peterz@...radead.org>, <vincent.guittot@...aro.org>, <juri.lelli@...hat.com>
CC: <dietmar.eggemann@....com>, <bsegall@...gle.com>, <wangtao554@...wei.com>,
	<tanghui20@...wei.com>, <zhangqiao22@...wei.com>,
	<linux-kernel@...r.kernel.org>, <nh-open-source@...zon.com>, "Madadi Vineeth
 Reddy" <vineethr@...ux.ibm.com>
Subject: Re: [PATCH RESEND] sched/fair: Only increment deadline once on yield


On 11.09.25 11:51, Fernand Sieber wrote:
> If a task yields, the scheduler may decide to pick it again. The task in
> turn may decide to yield immediately or shortly after, leading to a tight
> loop of yields.
>
> If there's another runnable task as this point, the deadline will be
> increased by the slice at each loop. This can cause the deadline to runaway
> pretty quickly, and subsequent elevated run delays later on as the task
> doesn't get picked again. The reason the scheduler can pick the same task
> again and again despite its deadline increasing is because it may be the
> only eligible task at that point.
>
> Fix this by updating the deadline only to one slice ahead.
>
> Note, we might want to consider iterating on the implementation of yield as
> follow up:
> * the yielding task could be forfeiting its remaining slice by
>    incrementing its vruntime correspondingly
> * in case of yield_to the yielding task could be donating its remaining
>    slice to the target task
>
> Fixes: 147f3efaa24182 ("sched/fair: Implement an EEVDF-like scheduling  policy")
> Reviewed-by: Madadi Vineeth Reddy <vineethr@...ux.ibm.com>
> Signed-off-by: Fernand Sieber <sieberf@...zon.com>
> Link: https://lore.kernel.org/r/20250401123622.584018-1-sieberf@amazon.com
> ---
> Resending it with no code changes.
> Adding "fixes" tag as per Alex's suggestion on thread.
> Adding a few more scheduler folks.
> ---
>   kernel/sched/fair.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
> index b173a059315c..d6a0d22d08d7 100644
> --- a/kernel/sched/fair.c
> +++ b/kernel/sched/fair.c
> @@ -8921,7 +8921,7 @@ static void yield_task_fair(struct rq *rq)
>   	 */
>   	rq_clock_skip_update(rq);
>
> -	se->deadline += calc_delta_fair(se->slice, se);
> +	se->deadline = se->vruntime + calc_delta_fair(se->slice, se);


Reviewed-by: Alexander Graf <graf@...zon.com>


Alex




Amazon Web Services Development Center Germany GmbH
Tamara-Danz-Str. 13
10243 Berlin
Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss
Eingetragen am Amtsgericht Charlottenburg unter HRB 257764 B
Sitz: Berlin
Ust-ID: DE 365 538 597