| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <9bea457a3255cdd8a925a2adab48b5b3bd4635df.camel@mediatek.com>
Date: Thu, 11 Sep 2025 11:24:15 +0000
From: CK Hu (胡俊光) <ck.hu@...iatek.com>
To: "robh@...nel.org" <robh@...nel.org>, "krzk+dt@...nel.org"
<krzk+dt@...nel.org>, Paul-pl Chen (陳柏霖)
<Paul-pl.Chen@...iatek.com>, "conor+dt@...nel.org" <conor+dt@...nel.org>,
AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
"chunkuang.hu@...nel.org" <chunkuang.hu@...nel.org>
CC: Sunny Shen (沈姍姍) <Sunny.Shen@...iatek.com>,
Sirius Wang (王皓昱) <Sirius.Wang@...iatek.com>,
Nancy Lin (林欣螢) <Nancy.Lin@...iatek.com>,
Xiandong Wang (王先冬)
<Xiandong.Wang@...iatek.com>, "linux-kernel@...r.kernel.org"
<linux-kernel@...r.kernel.org>, "dri-devel@...ts.freedesktop.org"
<dri-devel@...ts.freedesktop.org>, Project_Global_Chrome_Upstream_Group
<Project_Global_Chrome_Upstream_Group@...iatek.com>,
"linux-mediatek@...ts.infradead.org" <linux-mediatek@...ts.infradead.org>,
Jason-JH Lin (林睿祥) <Jason-JH.Lin@...iatek.com>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
"fshao@...omium.org" <fshao@...omium.org>, "p.zabel@...gutronix.de"
<p.zabel@...gutronix.de>, Singo Chang (張興國)
<Singo.Chang@...iatek.com>, "linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>, "matthias.bgg@...il.com"
<matthias.bgg@...il.com>, "treapking@...omium.org" <treapking@...omium.org>
Subject: Re: [PATCH v4 14/19] drm/mediatek: add EXDMA support for MT8196
On Thu, 2025-08-28 at 16:07 +0800, Paul Chen wrote:
> From: Nancy Lin <nancy.lin@...iatek.com>
>
> EXDMA is a DMA engine for reading data from DRAM with
> various DRAM footprints and data formats. For input
> sources in certain color formats and color domains,
> EXDMA also includes a color transfer function to
> process pixels into a consistent color domain.
>
> Signed-off-by: Nancy Lin <nancy.lin@...iatek.com>
> Signed-off-by: Paul-pl Chen <paul-pl.chen@...iatek.com>
> ---
[snip]
> diff --git a/drivers/gpu/drm/mediatek/mtk_disp_exdma.c b/drivers/gpu/drm/mediatek/mtk_disp_exdma.c
> new file mode 100644
> index 000000000000..9acb5da29712
> --- /dev/null
> +++ b/drivers/gpu/drm/mediatek/mtk_disp_exdma.c
> @@ -0,0 +1,359 @@
> +// SPDX-License-Identifier: GPL-2.0-only
> +/*
> + * Copyright (c) 2025 MediaTek Inc.
> + */
> +
> +#include <drm/drm_fourcc.h>
Alphabetic order.
> +#include <drm/drm_blend.h>
> +#include <drm/drm_framebuffer.h>
> +#include <linux/clk.h>
> +#include <linux/component.h>
> +#include <linux/of_platform.h>
Alphabetic order.
> +#include <linux/of_address.h>
> +#include <linux/of_device.h>
> +#include <linux/platform_device.h>
> +#include <linux/pm_runtime.h>
> +#include <linux/soc/mediatek/mtk-cmdq.h>
> +
> +#include "mtk_disp_drv.h"
> +#include "mtk_drm_drv.h"
Alphabetic order.
> +#include "mtk_disp_ovl.h"
> +
> +#define DISP_REG_OVL_EXDMA_EN_CON 0xc
> +#define OVL_EXDMA_OP_8BIT_MODE BIT(4)
> +#define OVL_EXDMA_HG_FOVL_EXDMA_CK_ON BIT(8)
> +#define OVL_EXDMA_HF_FOVL_EXDMA_CK_ON BIT(10)
> +#define DISP_REG_OVL_EXDMA_DATAPATH_CON 0x014
> +#define OVL_EXDMA_DATAPATH_CON_LAYER_SMI_ID_EN BIT(0)
> +#define OVL_EXDMA_DATAPATH_CON_GCLAST_EN BIT(24)
> +#define OVL_EXDMA_DATAPATH_CON_HDR_GCLAST_EN BIT(25)
> +#define DISP_REG_OVL_EXDMA_EN 0x020
> +#define OVL_EXDMA_EN BIT(0)
> +#define DISP_REG_OVL_EXDMA_RST 0x024
> +#define OVL_EXDMA_RST BIT(0)
> +#define DISP_REG_OVL_EXDMA_ROI_SIZE 0x030
> +#define DISP_REG_OVL_EXDMA_L0_EN 0x040
> +#define OVL_EXDMA_L0_EN BIT(0)
> +#define DISP_REG_OVL_EXDMA_L0_OFFSET 0x044
> +#define DISP_REG_OVL_EXDMA_SRC_SIZE 0x048
> +#define DISP_REG_OVL_EXDMA_L0_CLRFMT 0x050
> +#define OVL_EXDMA_CON_FLD_CLRFMT GENMASK(3, 0)
> +#define OVL_EXDMA_CON_CLRFMT_MAN BIT(4)
> +#define OVL_EXDMA_CON_FLD_CLRFMT_NB GENMASK(9, 8)
> +#define OVL_EXDMA_CON_CLRFMT_NB_10_BIT BIT(8)
> +#define OVL_EXDMA_CON_BYTE_SWAP BIT(16)
> +#define OVL_EXDMA_CON_RGB_SWAP BIT(17)
> +#define DISP_REG_OVL_EXDMA_RDMA0_CTRL 0x100
> +#define OVL_EXDMA_RDMA0_EN BIT(0)
> +#define DISP_REG_OVL_EXDMA_RDMA_BURST_CON1 0x1f4
> +#define OVL_EXDMA_RDMA_BURST_CON1_BURST16_EN BIT(28)
> +#define OVL_EXDMA_RDMA_BURST_CON1_DDR_EN BIT(30)
> +#define OVL_EXDMA_RDMA_BURST_CON1_DDR_ACK_EN BIT(31)
> +#define DISP_REG_OVL_EXDMA_DUMMY_REG 0x200
> +#define OVL_EXDMA_EXT_DDR_EN_OPT BIT(2)
> +#define OVL_EXDMA_FORCE_EXT_DDR_EN BIT(3)
> +#define DISP_REG_OVL_EXDMA_GDRDY_PRD 0x208
> +#define DISP_REG_OVL_EXDMA_PITCH_MSB 0x2f0
> +#define OVL_EXDMA_L0_SRC_PITCH_MSB_MASK GENMASK(3, 0)
> +#define DISP_REG_OVL_EXDMA_PITCH 0x2f4
> +#define OVL_EXDMA_L0_SRC_PITCH GENMASK(15, 0)
> +#define OVL_EXDMA_L0_CONST_BLD BIT(28)
> +#define OVL_EXDMA_L0_SRC_PITCH_MASK GENMASK(15, 0)
OVL_EXDMA_L0_SRC_PITCH_MASK is useless, drop it.
> +#define DISP_REG_OVL_EXDMA_L0_GUSER_EXT 0x2fc
> +#define OVL_EXDMA_RDMA0_L0_VCSEL BIT(5)
> +#define OVL_EXDMA_RDMA0_HDR_L0_VCSEL BIT(21)
> +#define DISP_REG_OVL_EXDMA_CON 0x300
> +#define OVL_EXDMA_CON_FLD_INT_MTX_SEL GENMASK(19, 16)
> +#define OVL_EXDMA_CON_INT_MTX_BT601_TO_RGB (6 << 16)
> +#define OVL_EXDMA_CON_INT_MTX_BT709_TO_RGB (7 << 16)
> +#define OVL_EXDMA_CON_INT_MTX_EN BIT(27)
> +#define DISP_REG_OVL_EXDMA_ADDR 0xf40
> +#define DISP_REG_OVL_EXDMA_MOUT 0xff0
> +#define OVL_EXDMA_MOUT_OUT_DATA BIT(0)
> +#define OVL_EXDMA_MOUT_BGCLR_OUT BIT(1)
> +
[snip]
> +void mtk_disp_exdma_start(struct device *dev)
> +{
> + struct mtk_disp_exdma *priv = dev_get_drvdata(dev);
> + unsigned int value = 0, mask = 0;
You would assign value to 'value' and 'mask' later, so it's not necessary to have initial value.
> +
> + /*
> + * This configuration enables dynamic power switching mechanism for EXDMA,
> + * also known as "SRT mode".
> + * Such configuration allows the system to achieve better power efficiency.
> + */
> + value = OVL_EXDMA_RDMA_BURST_CON1_BURST16_EN | OVL_EXDMA_RDMA_BURST_CON1_DDR_ACK_EN;
> + mask = OVL_EXDMA_RDMA_BURST_CON1_BURST16_EN | OVL_EXDMA_RDMA_BURST_CON1_DDR_EN |
> + OVL_EXDMA_RDMA_BURST_CON1_DDR_ACK_EN;
> + mtk_ddp_write_mask(NULL, value, &priv->cmdq_reg, priv->regs,
> + DISP_REG_OVL_EXDMA_RDMA_BURST_CON1, mask);
> +
> + /*
> + * The dummy register is used in the configuration of the EXDMA engine to
> + * signal ddren_request, and get ddren_ack before accessing the DRAM to
> + * ensure data transfers occur normally.
> + * primarily functions as a DMA engine for reading data from DRAM with
> + * various DRAM footprints and data formats.
> + */
> + value = OVL_EXDMA_EXT_DDR_EN_OPT | OVL_EXDMA_FORCE_EXT_DDR_EN;
> +
> + mtk_ddp_write_mask(NULL, value, &priv->cmdq_reg, priv->regs,
> + DISP_REG_OVL_EXDMA_DUMMY_REG, value);
> +
> + value = OVL_EXDMA_DATAPATH_CON_LAYER_SMI_ID_EN |
> + OVL_EXDMA_DATAPATH_CON_HDR_GCLAST_EN |
> + OVL_EXDMA_DATAPATH_CON_GCLAST_EN;
> +
> + mtk_ddp_write_mask(NULL, value, &priv->cmdq_reg, priv->regs,
> + DISP_REG_OVL_EXDMA_DATAPATH_CON, value);
> +
> + mtk_ddp_write_mask(NULL, OVL_EXDMA_MOUT_BGCLR_OUT, &priv->cmdq_reg,
> + priv->regs, DISP_REG_OVL_EXDMA_MOUT,
> + OVL_EXDMA_MOUT_BGCLR_OUT | OVL_EXDMA_MOUT_OUT_DATA);
> +
> + mtk_ddp_write(NULL, ~0, &priv->cmdq_reg, priv->regs, DISP_REG_OVL_EXDMA_GDRDY_PRD);
> +
> + value = OVL_EXDMA_HG_FOVL_EXDMA_CK_ON | OVL_EXDMA_HF_FOVL_EXDMA_CK_ON |
> + OVL_EXDMA_OP_8BIT_MODE;
> + mtk_ddp_write_mask(NULL, value, &priv->cmdq_reg, priv->regs,
> + DISP_REG_OVL_EXDMA_EN_CON, value);
> + mtk_ddp_write_mask(NULL, OVL_EXDMA_EN, &priv->cmdq_reg, priv->regs,
> + DISP_REG_OVL_EXDMA_EN, OVL_EXDMA_EN);
> +}
> +
[snip]
> +void mtk_disp_exdma_layer_config(struct device *dev, struct mtk_plane_state *state,
> + struct cmdq_pkt *cmdq_pkt)
> +{
> + struct mtk_disp_exdma *priv = dev_get_drvdata(dev);
> + struct mtk_plane_pending_state *pending = &state->pending;
> + const struct drm_format_info *fmt_info = drm_format_info(pending->format);
> + bool csc_enable = (fmt_info) ? fmt_info->is_yuv : false;
> + u32 blend_mode = mtk_ovl_get_blend_mode(state, MTK_OVL_SUPPORT_BLEND_MODES);
> + u32 val;
> +
> + if (!pending->enable || pending->height == 0 || pending->width == 0 ||
> + pending->x > priv->data->max_size || pending->y > priv->data->max_size) {
> + mtk_ddp_write_mask(cmdq_pkt, 0, &priv->cmdq_reg, priv->regs,
> + DISP_REG_OVL_EXDMA_RDMA0_CTRL, OVL_EXDMA_RDMA0_EN);
> + mtk_ddp_write_mask(cmdq_pkt, 0, &priv->cmdq_reg, priv->regs,
> + DISP_REG_OVL_EXDMA_L0_EN, OVL_EXDMA_L0_EN);
> + return;
> + }
> +
> + mtk_ddp_write(cmdq_pkt, pending->height << 16 | pending->width, &priv->cmdq_reg,
> + priv->regs, DISP_REG_OVL_EXDMA_ROI_SIZE);
> +
> + mtk_ddp_write(cmdq_pkt, pending->height << 16 | pending->width, &priv->cmdq_reg,
> + priv->regs, DISP_REG_OVL_EXDMA_SRC_SIZE);
> +
> + mtk_ddp_write(cmdq_pkt, pending->y << 16 | pending->x, &priv->cmdq_reg, priv->regs,
> + DISP_REG_OVL_EXDMA_L0_OFFSET);
> + mtk_ddp_write(cmdq_pkt, pending->addr, &priv->cmdq_reg,
> + priv->regs, DISP_REG_OVL_EXDMA_ADDR);
> +
> + val = pending->pitch;
> + if (mtk_ovl_is_ignore_pixel_alpha(state, blend_mode))
> + val |= OVL_EXDMA_L0_CONST_BLD;
> +
> + mtk_ddp_write_mask(cmdq_pkt, val, &priv->cmdq_reg, priv->regs, DISP_REG_OVL_EXDMA_PITCH,
> + OVL_EXDMA_L0_CONST_BLD | OVL_EXDMA_L0_SRC_PITCH);
> + mtk_ddp_write_mask(cmdq_pkt, pending->pitch >> 16, &priv->cmdq_reg, priv->regs,
> + DISP_REG_OVL_EXDMA_PITCH_MSB, OVL_EXDMA_L0_SRC_PITCH_MSB_MASK);
> +
> + val = mtk_disp_exdma_color_convert(pending->color_encoding);
> + if (csc_enable)
> + val |= OVL_EXDMA_CON_INT_MTX_EN;
> + mtk_ddp_write_mask(cmdq_pkt, val, &priv->cmdq_reg, priv->regs, DISP_REG_OVL_EXDMA_CON,
> + OVL_EXDMA_CON_FLD_INT_MTX_SEL | OVL_EXDMA_CON_INT_MTX_EN);
> +
> + val = mtk_ovl_fmt_convert(pending->format, blend_mode, true, false, 0,
> + OVL_EXDMA_CON_CLRFMT_MAN, OVL_EXDMA_CON_BYTE_SWAP,
> + OVL_EXDMA_CON_RGB_SWAP);
> + if (mtk_ovl_is_10bit_rgb(pending->format))
> + val |= OVL_EXDMA_CON_CLRFMT_NB_10_BIT;
> + mtk_ddp_write_mask(cmdq_pkt, val, &priv->cmdq_reg, priv->regs,
> + DISP_REG_OVL_EXDMA_L0_CLRFMT,
> + OVL_EXDMA_CON_RGB_SWAP | OVL_EXDMA_CON_BYTE_SWAP |
> + OVL_EXDMA_CON_CLRFMT_MAN | OVL_EXDMA_CON_FLD_CLRFMT |
> + OVL_EXDMA_CON_FLD_CLRFMT_NB);
The mask should include OVL_EXDMA_CON_CLRFMT_NB_10_BIT.
> +
> + val = OVL_EXDMA_RDMA0_L0_VCSEL | OVL_EXDMA_RDMA0_HDR_L0_VCSEL;
What are these? Add comment for these.
If this is constant, why not set it when start?
> + mtk_ddp_write_mask(cmdq_pkt, val, &priv->cmdq_reg, priv->regs,
> + DISP_REG_OVL_EXDMA_L0_GUSER_EXT, val);
> +
> + mtk_ddp_write_mask(cmdq_pkt, OVL_EXDMA_RDMA0_EN, &priv->cmdq_reg, priv->regs,
> + DISP_REG_OVL_EXDMA_RDMA0_CTRL, OVL_EXDMA_RDMA0_EN);
> + mtk_ddp_write_mask(cmdq_pkt, OVL_EXDMA_L0_EN, &priv->cmdq_reg, priv->regs,
> + DISP_REG_OVL_EXDMA_L0_EN, OVL_EXDMA_L0_EN);
> +}
> +
[snip]
> +static const struct mtk_disp_exdma_data mt8196_disp_exdma_driver_data = {
> + .max_size = 8191,
Now only one SoC has EXDMA, so it's not necessary to have a SoC data.
Use a macro to define it.
#define EXDMA_MAX_SIZE 8191
Regards,
CK
> +};
> +
Powered by blists - more mailing lists