linux-kernel - RE: [PATCH 2/7] drm: writeback: Modify writeback init helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <DM3PPF208195D8D0D1CAE876CBDADD3B82BE309A@DM3PPF208195D8D.namprd11.prod.outlook.com>
Date: Thu, 11 Sep 2025 11:44:14 +0000
From: "Kandpal, Suraj" <suraj.kandpal@...el.com>
To: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
CC: "kernel-list@...pberrypi.com" <kernel-list@...pberrypi.com>,
	"amd-gfx@...ts.freedesktop.org" <amd-gfx@...ts.freedesktop.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-renesas-soc@...r.kernel.org" <linux-renesas-soc@...r.kernel.org>,
	"linux-arm-msm@...r.kernel.org" <linux-arm-msm@...r.kernel.org>,
	"freedreno@...ts.freedesktop.org" <freedreno@...ts.freedesktop.org>,
	"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
	"intel-xe@...ts.freedesktop.org" <intel-xe@...ts.freedesktop.org>,
	"intel-gfx@...ts.freedesktop.org" <intel-gfx@...ts.freedesktop.org>,
	"Nautiyal, Ankit K" <ankit.k.nautiyal@...el.com>, "Murthy, Arun R"
	<arun.r.murthy@...el.com>, "Shankar, Uma" <uma.shankar@...el.com>, "Nikula,
 Jani" <jani.nikula@...el.com>, "harry.wentland@....com"
	<harry.wentland@....com>, "siqueira@...lia.com" <siqueira@...lia.com>,
	"alexander.deucher@....com" <alexander.deucher@....com>,
	"christian.koenig@....com" <christian.koenig@....com>, "airlied@...il.com"
	<airlied@...il.com>, "simona@...ll.ch" <simona@...ll.ch>,
	"liviu.dudau@....com" <liviu.dudau@....com>,
	"maarten.lankhorst@...ux.intel.com" <maarten.lankhorst@...ux.intel.com>,
	"mripard@...nel.org" <mripard@...nel.org>, "robin.clark@....qualcomm.com"
	<robin.clark@....qualcomm.com>, "abhinav.kumar@...ux.dev"
	<abhinav.kumar@...ux.dev>, "tzimmermann@...e.de" <tzimmermann@...e.de>,
	"jessica.zhang@....qualcomm.com" <jessica.zhang@....qualcomm.com>,
	"sean@...rly.run" <sean@...rly.run>, "marijn.suijten@...ainline.org"
	<marijn.suijten@...ainline.org>, "laurent.pinchart+renesas@...asonboard.com"
	<laurent.pinchart+renesas@...asonboard.com>, "mcanal@...lia.com"
	<mcanal@...lia.com>, "dave.stevenson@...pberrypi.com"
	<dave.stevenson@...pberrypi.com>, "tomi.valkeinen+renesas@...asonboard.com"
	<tomi.valkeinen+renesas@...asonboard.com>,
	"kieran.bingham+renesas@...asonboard.com"
	<kieran.bingham+renesas@...asonboard.com>, "louis.chauvet@...tlin.com"
	<louis.chauvet@...tlin.com>
Subject: RE: [PATCH 2/7] drm: writeback: Modify writeback init helpers

> > Now with drm_writeback_connector moved to drm_connector it makes more
> > sense use drm_connector as an argument rather than drm_connector.
> 
> than drm_writeback_connector

Sure will fix this.

> 
> > The writeback connector can easily be derived from drm_connector.
> >
> > Signed-off-by: Suraj Kandpal <suraj.kandpal@...el.com>
> > ---
> >  .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_wb.c |  2 +-
> > .../drm/arm/display/komeda/komeda_wb_connector.c |  5 +----
> >  drivers/gpu/drm/arm/malidp_mw.c                  |  2 +-
> >  drivers/gpu/drm/drm_writeback.c                  | 16 ++++++++--------
> >  drivers/gpu/drm/msm/disp/dpu1/dpu_writeback.c    |  2 +-
> >  .../gpu/drm/renesas/rcar-du/rcar_du_writeback.c  |  3 +--
> >  drivers/gpu/drm/vc4/vc4_txp.c                    |  2 +-
> >  drivers/gpu/drm/vkms/vkms_writeback.c            |  4 ++--
> >  include/drm/drm_writeback.h                      |  4 ++--
> >  9 files changed, 18 insertions(+), 22 deletions(-)
> >
> > @@ -338,13 +338,13 @@ static void
> drm_writeback_connector_cleanup(struct drm_device *dev,
> >   * Returns: 0 on success, or a negative error code
> >   */
> >  int drmm_writeback_connector_init(struct drm_device *dev,
> > -				  struct drm_writeback_connector
> *wb_connector,
> > +				  struct drm_connector *connector,
> >  				  const struct drm_connector_funcs
> *con_funcs,
> >  				  struct drm_encoder *enc,
> >  				  const u32 *formats, int n_formats)  {
> > -	struct drm_connector *connector =
> > -		drm_writeback_to_connector(wb_connector);
> > +	struct drm_writeback_connector *wb_connector =
> > +		drm_connector_to_writeback(connector);
> 
> You can use &connector->writeback without extra wrappers.

Hmm just kept it around to make abstract the internal structure, will help with future refactors if any.
Its anyways a static inline function.
If that doesn't make sense I can do it the way as you suggested and also add a patch to remove this helper altogether

Regards,
Suraj Kandpal