[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20250911112756.4008435-2-damon.ding@rock-chips.com>
Date: Thu, 11 Sep 2025 19:27:53 +0800
From: Damon Ding <damon.ding@...k-chips.com>
To: andrzej.hajda@...el.com,
neil.armstrong@...aro.org,
rfoss@...nel.org
Cc: Laurent.pinchart@...asonboard.com,
jonas@...boo.se,
jernej.skrabec@...il.com,
maarten.lankhorst@...ux.intel.com,
mripard@...nel.org,
tzimmermann@...e.de,
airlied@...il.com,
simona@...ll.ch,
dmitry.baryshkov@...aro.org,
l.stach@...gutronix.de,
dianders@...omium.org,
m.szyprowski@...sung.com,
andy.yan@...k-chips.com,
dri-devel@...ts.freedesktop.org,
linux-kernel@...r.kernel.org,
Damon Ding <damon.ding@...k-chips.com>
Subject: [PATCH v2 1/4] drm/bridge: analogix_dp: Apply DP helper API drm_dp_dpcd_read_link_status()
Use existing DP helper API to read link status related DPCDs.
Signed-off-by: Damon Ding <damon.ding@...k-chips.com>
Tested-by: Marek Szyprowski <m.szyprowski@...sung.com>
---
drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 13 ++++++-------
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
index ed35e567d117..6a3f3fb0ec0a 100644
--- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
+++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
@@ -388,13 +388,13 @@ static int analogix_dp_process_clock_recovery(struct analogix_dp_device *dp)
{
int lane, lane_count, retval;
u8 voltage_swing, pre_emphasis, training_lane;
- u8 link_status[2], adjust_request[2];
+ u8 link_status[DP_LINK_STATUS_SIZE], adjust_request[2];
usleep_range(100, 101);
lane_count = dp->link_train.lane_count;
- retval = drm_dp_dpcd_read(&dp->aux, DP_LANE0_1_STATUS, link_status, 2);
+ retval = drm_dp_dpcd_read_link_status(&dp->aux, link_status);
if (retval < 0)
return retval;
@@ -454,13 +454,13 @@ static int analogix_dp_process_equalizer_training(struct analogix_dp_device *dp)
{
int lane_count, retval;
u32 reg;
- u8 link_align, link_status[2], adjust_request[2];
+ u8 link_align, link_status[DP_LINK_STATUS_SIZE], adjust_request[2];
usleep_range(400, 401);
lane_count = dp->link_train.lane_count;
- retval = drm_dp_dpcd_read(&dp->aux, DP_LANE0_1_STATUS, link_status, 2);
+ retval = drm_dp_dpcd_read_link_status(&dp->aux, link_status);
if (retval < 0)
return retval;
@@ -619,7 +619,7 @@ static int analogix_dp_full_link_train(struct analogix_dp_device *dp,
static int analogix_dp_fast_link_train(struct analogix_dp_device *dp)
{
int ret;
- u8 link_align, link_status[2];
+ u8 link_align, link_status[DP_LINK_STATUS_SIZE];
analogix_dp_set_link_bandwidth(dp, dp->link_train.link_rate);
ret = analogix_dp_wait_pll_locked(dp);
@@ -661,8 +661,7 @@ static int analogix_dp_fast_link_train(struct analogix_dp_device *dp)
return ret;
}
- ret = drm_dp_dpcd_read(&dp->aux, DP_LANE0_1_STATUS, link_status,
- 2);
+ ret = drm_dp_dpcd_read_link_status(&dp->aux, link_status);
if (ret < 0) {
DRM_DEV_ERROR(dp->dev, "Read link status failed %d\n",
ret);
--
2.34.1
Powered by blists - more mailing lists