linux-kernel - Re: [PATCH] coresight: trbe: Use scope-based resource management in arm_trbe_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ef091856-8803-4c68-a994-b995ddc0d4ab@web.de>
Date: Fri, 12 Sep 2025 14:37:58 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Leo Yan <leo.yan@....com>, Anshuman Khandual <anshuman.khandual@....com>,
 coresight@...ts.linaro.org, linux-arm-kernel@...ts.infradead.org
Cc: Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
 James Clark <james.clark@...aro.org>, Mike Leach <mike.leach@...aro.org>,
 Suzuki K Poulose <suzuki.poulose@....com>,
 Tamas Zsoldos <tamas.zsoldos@....com>, kernel-janitors@...r.kernel.org,
 LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] coresight: trbe: Use scope-based resource management in
 arm_trbe_alloc_buffer()

>> Seems like a good idea though. But please keep the local variable
>> declaration in the current place which is bit cleaner and reduces
>> code churn as well.
> 
> Though include/linux/cleanup.h suggests to "always define and assign
> variables in one statement" to avoid potential interdependency problem
> with lock, this is not concerned in arm_trbe_alloc_buffer().
> 
> So I bias to Anshuman's suggestion of declaring variables at the top
> of the function, as this is the style widely used in the kernel.

Does anything hinder you to follow the mentioned cleanup advice more?

Regards,
Markus