linux-kernel - Re: [PATCH v2 08/10] dmaengine: imx-sdma: make use of devm_add_action_or_reset to unregiser the dma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250912040252.GH5808@nxa18884-linux.ap.freescale.net>
Date: Fri, 12 Sep 2025 12:02:52 +0800
From: Peng Fan <peng.fan@....nxp.com>
To: Marco Felsch <m.felsch@...gutronix.de>
Cc: Vinod Koul <vkoul@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	Pengutronix Kernel Team <kernel@...gutronix.de>,
	Fabio Estevam <festevam@...il.com>,
	Jiada Wang <jiada_wang@...tor.com>, dmaengine@...r.kernel.org,
	imx@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 08/10] dmaengine: imx-sdma: make use of
 devm_add_action_or_reset to unregiser the dma_device

On Thu, Sep 11, 2025 at 11:56:49PM +0200, Marco Felsch wrote:
>Make use of the devm_add_action_or_reset() to register a custom devm_
>release hook. This is required to turn off the IRQs before calling
>dma_async_device_unregister().
>
>Furthermore it removes the last goto error handling within probe() and
>trims the remove().
>
>Make use of disable_irq() and let the devm-irq do the job to free the
>IRQ, because the only purpose of using devm_free_irq() was to disable
>the IRQ before calling dma_async_device_unregister().
>
>Signed-off-by: Marco Felsch <m.felsch@...gutronix.de>

Reviewed-by: Peng Fan <peng.fan@....com>