linux-kernel - Re: [PATCH] mmc: mvsdio: Fix dma_unmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPDyKFq=3RANVUpZEJMTLH2YewJN=_mV-kM7DBb4-hhHPFv4oA@mail.gmail.com>
Date: Fri, 12 Sep 2025 15:34:04 +0200
From: Ulf Hansson <ulf.hansson@...aro.org>
To: Thomas Fourier <fourier.thomas@...il.com>
Cc: Nicolas Pitre <nico@...xnic.net>, Ingo Molnar <mingo@...nel.org>, 
	Thomas Gleixner <tglx@...utronix.de>, Binbin Zhou <zhoubinbin@...ngson.cn>, 
	Linus Walleij <linus.walleij@...aro.org>, Pierre Ossman <drzeus@...eus.cx>, linux-mmc@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mmc: mvsdio: Fix dma_unmap_sg() nents value

On Tue, 26 Aug 2025 at 09:59, Thomas Fourier <fourier.thomas@...il.com> wrote:
>
> The dma_unmap_sg() functions should be called with the same nents as the
> dma_map_sg(), not the value the map function returned.
>
> Fixes: 236caa7cc351 ("mmc: SDIO driver for Marvell SoCs")
> Signed-off-by: Thomas Fourier <fourier.thomas@...il.com>

Applied for fixes and by adding a stable tag, thanks!

Kind regards
Uffe


> ---
>  drivers/mmc/host/mvsdio.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/mvsdio.c b/drivers/mmc/host/mvsdio.c
> index a9e6277789ba..79df2fa89a3f 100644
> --- a/drivers/mmc/host/mvsdio.c
> +++ b/drivers/mmc/host/mvsdio.c
> @@ -292,7 +292,7 @@ static u32 mvsd_finish_data(struct mvsd_host *host, struct mmc_data *data,
>                 host->pio_ptr = NULL;
>                 host->pio_size = 0;
>         } else {
> -               dma_unmap_sg(mmc_dev(host->mmc), data->sg, host->sg_frags,
> +               dma_unmap_sg(mmc_dev(host->mmc), data->sg, data->sg_len,
>                              mmc_get_dma_dir(data));
>         }
>
> --
> 2.43.0
>