linux-kernel - Re: IWL Error Log Dump since 6.17.0-rc5

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <35b1fd7b.aa06.1993e2b7ce5.Coremail.00107082@163.com>
Date: Fri, 12 Sep 2025 21:44:21 +0800 (CST)
From: "David Wang" <00107082@....com>
To: "Johannes Berg" <johannes@...solutions.net>
Cc: miriam.rachel.korenblit@...el.com, linux-wireless@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: IWL Error Log Dump since 6.17.0-rc5


At 2025-09-10 16:31:33, "Johannes Berg" <johannes@...solutions.net> wrote:
>On Wed, 2025-09-10 at 15:47 +0800, David Wang wrote:
>> Hi, 
>> 
>> I think those error dump is introduced by commit 586e3cb33ba6890054b95aa0ade0a165890efabd("wifi: iwlwifi: fix byte count table for old devices")
>> 
>> My wireless pcie card has device_family 15 which is less than IWL_DEVICE_FAMILY_9000, and the changes in the commit have changed the behavior for my devices.
>> 
>> -       if (trans->mac_cfg->device_family < IWL_DEVICE_FAMILY_AX210)
>> +       if (trans->mac_cfg->device_family >= IWL_DEVICE_FAMILY_9000 &&
>> +           trans->mac_cfg->device_family < IWL_DEVICE_FAMILY_AX210)
>>                 len = DIV_ROUND_UP(len, 4);
>
>I think I just got confused, and that 9000 should be 7000. Presumably
>that'd work for you, I'll send a patch.
>
>johannes


Hi, 

My system has been run for days and no IWL error dumps & reset happened.
I think I can confirm that my wireless card needs the length adjustment.

Some information about my cards:

[    5.067265] iwlwifi 0000:21:00.0: enabling device (0000 -> 0002)
[    5.068798] iwlwifi 0000:21:00.0: Detected crf-id 0x0, cnv-id 0x0 wfpm id 0x0
[    5.068809] iwlwifi 0000:21:00.0: PCI dev 08b1/c070, rev=0x144, rfid=0xd55555d5
[    5.068813] iwlwifi 0000:21:00.0: device family: 15  <-- 
[    5.068816] iwlwifi 0000:21:00.0: Detected Intel(R) Dual Band Wireless AC 7260
[    5.075593] iwlwifi 0000:21:00.0: loaded firmware version 17.bfb58538.0 7260-17.ucode op_mode iwlmvm

$ lspci
...
21:00.0 Network controller: Intel Corporation Wireless 7260 (rev bb)
...


My device match the config in drivers/net/wireless/intel/iwlwifi/pcie/drv.c:

263         {IWL_PCI_DEVICE(0x08B1, 0xC070, iwl7000_mac_cfg)},

iwl7000_mac_cfg is defined as:

 88 const struct iwl_mac_cfg iwl7000_mac_cfg = { 
 89         .device_family = IWL_DEVICE_FAMILY_7000, 
 90         .base = &iwl7000_base,
 91 };

And indeed, it is IWL_DEVICE_FAMILY_7000

FYI
David