linux-kernel - Re: [PATCH] staging: rtl8723bs: fix coding style in hal_com

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2025091233-showman-dill-3d17@gregkh>
Date: Fri, 12 Sep 2025 15:45:58 +0200
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Akiyoshi Kurita <weibu@...admin.org>
Cc: Philipp Hortmann <philipp.g.hortmann@...il.com>,
	linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: fix coding style in hal_com_phycfg.c

On Mon, Sep 08, 2025 at 11:46:41PM +0900, Akiyoshi Kurita wrote:
> The function definition for phy_StoreTxPowerByRateBase() did not
> follow the kernel coding style.
> 
> Move the closing parenthesis to the same line as the argument to fix
> the style issue reported by checkpatch.pl.
> 
> Signed-off-by: Akiyoshi Kurita <weibu@...admin.org>
> ---
>  drivers/staging/rtl8723bs/hal/hal_com_phycfg.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c b/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c
> index d5649e7d8f99..f137ec747ab3 100644
> --- a/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c
> +++ b/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c
> @@ -60,9 +60,7 @@ phy_SetTxPowerByRateBase(struct adapter *Adapter, u8 RfPath,
>  }
>  
>  static void
> -phy_StoreTxPowerByRateBase(
> -struct adapter *padapter
> -	)
> +phy_StoreTxPowerByRateBase(struct adapter *padapter)

This really should end up being:

static void phy_StoreTxPowerByRateBase(struct adapter *padapter)

right?

thanks,

greg k-h