linux-kernel - Re: [PATCH v3] mips: math-emu: replace deprecated strcpy() in me-debugfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aMQJWlDsvZ8sADQ1@alpha.franken.de>
Date: Fri, 12 Sep 2025 13:51:54 +0200
From: Thomas Bogendoerfer <tsbogend@...ha.franken.de>
To: Osama Abdelkader <osama.abdelkader@...il.com>
Cc: macro@...am.me.uk, linux-mips@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] mips: math-emu: replace deprecated strcpy() in
 me-debugfs

On Thu, Sep 04, 2025 at 09:25:25PM +0200, Osama Abdelkader wrote:
> use strscpy() instead of deprecated strcpy().
> 
> Signed-off-by: Osama Abdelkader <osama.abdelkader@...il.com>
> ---
> v2:
> change function signature to get len and the caller.
> v3:
> use same parameters and arguments order
> ---
>  arch/mips/math-emu/me-debugfs.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/mips/math-emu/me-debugfs.c b/arch/mips/math-emu/me-debugfs.c
> index d5ad76b2bb67..49bf2b827ce2 100644
> --- a/arch/mips/math-emu/me-debugfs.c
> +++ b/arch/mips/math-emu/me-debugfs.c
> @@ -37,11 +37,11 @@ DEFINE_SIMPLE_ATTRIBUTE(fops_fpuemu_stat, fpuemu_stat_get, NULL, "%llu\n");
>   * used in debugfs item names to be clearly associated to corresponding
>   * MIPS FPU instructions.
>   */
> -static void adjust_instruction_counter_name(char *out_name, char *in_name)
> +static void adjust_instruction_counter_name(char *out_name, char *in_name, size_t len)
>  {
>  	int i = 0;
>  
> -	strcpy(out_name, in_name);
> +	strscpy(out_name, in_name, len);
>  	while (in_name[i] != '\0') {
>  		if (out_name[i] == '_')
>  			out_name[i] = '.';
> @@ -226,7 +226,7 @@ do {									\
>  
>  #define FPU_STAT_CREATE_EX(m)						\
>  do {									\
> -	adjust_instruction_counter_name(name, #m);			\
> +	adjust_instruction_counter_name(name, #m, sizeof(name));			\
>  									\
>  	debugfs_create_file(name, 0444, fpuemu_debugfs_inst_dir,	\
>  				(void *)FPU_EMU_STAT_OFFSET(m),		\
> -- 
> 2.43.0

applied to mips-next.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]