linux-kernel - Re: [PATCH v11 06/23] CXL/AER: Introduce rch_aer.c into AER driver for handling CXL RCH errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52a64372-098b-4656-a1c0-1a6cfee126e3@amd.com>
Date: Fri, 12 Sep 2025 08:59:37 -0500
From: "Bowman, Terry" <terry.bowman@....com>
To: Lukas Wunner <lukas@...ner.de>, Dave Jiang <dave.jiang@...el.com>
Cc: dave@...olabs.net, jonathan.cameron@...wei.com,
 alison.schofield@...el.com, dan.j.williams@...el.com, bhelgaas@...gle.com,
 shiju.jose@...wei.com, ming.li@...omail.com,
 Smita.KoralahalliChannabasappa@....com, rrichter@....com,
 dan.carpenter@...aro.org, PradeepVineshReddy.Kodamati@....com,
 Benjamin.Cheatham@....com, sathyanarayanan.kuppuswamy@...ux.intel.com,
 linux-cxl@...r.kernel.org, alucerop@....com, ira.weiny@...el.com,
 linux-kernel@...r.kernel.org, linux-pci@...r.kernel.org
Subject: Re: [PATCH v11 06/23] CXL/AER: Introduce rch_aer.c into AER driver
 for handling CXL RCH errors



On 8/29/2025 3:39 AM, Lukas Wunner wrote:
> On Thu, Aug 28, 2025 at 01:53:35PM -0700, Dave Jiang wrote:
>> On 8/26/25 6:35 PM, Terry Bowman wrote:
>>>  drivers/cxl/Kconfig        |   9 +++-
>>>  drivers/cxl/core/ras.c     |   3 ++
>>>  drivers/pci/pci.h          |  20 +++++++
>>>  drivers/pci/pcie/Makefile  |   1 +
>>>  drivers/pci/pcie/aer.c     | 108 +++----------------------------------
>>>  drivers/pci/pcie/rch_aer.c |  99 ++++++++++++++++++++++++++++++++++
>> I wonder if this should be cxl_rch_aer.c to be clear that it's cxl
>> related code.
> I'd prefer an "aer_" prefix at the beginning of filenames,
> but maybe that's just me...
>
> Thanks,
>
> Lukas

Hi Lukas,

After discussing off-thread I understand you prefer changing the name here to be 
drivers/pci/pcie/aer_cxl_rch.c. 

Also, the non-RCH changes should be added to a file named drivers/pci/pcie/aer_cxl_vh.c 
in the later patch (CXL/AER: Introduce cxl_aer.c into AER driver for forwarding CXL errors).

Can you confirm the name changes are as you prefer?

Terry