linux-kernel - Re: [PATCH v3 0/4] TDX: Clean up the definitions of TDX TD ATTRIBUTES

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ef18afaf-9372-4c93-a370-a079cbb89deb@intel.com>
Date: Fri, 12 Sep 2025 11:24:33 +0800
From: Xiaoyao Li <xiaoyao.li@...el.com>
To: "Kirill A. Shutemov" <kas@...nel.org>,
 Dave Hansen <dave.hansen@...ux.intel.com>,
 Sean Christopherson <seanjc@...gle.com>, Paolo Bonzini <pbonzini@...hat.com>
Cc: Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>,
 Borislav Petkov <bp@...en8.de>, "H. Peter Anvin" <hpa@...or.com>,
 linux-coco@...ts.linux.dev, kvm@...r.kernel.org,
 linux-kernel@...r.kernel.org, x86@...nel.org,
 Rick Edgecombe <rick.p.edgecombe@...el.com>, Kai Huang
 <kai.huang@...el.com>, binbin.wu@...ux.intel.com, yan.y.zhao@...el.com,
 reinette.chatre@...el.com, adrian.hunter@...el.com, tony.lindgren@...el.com
Subject: Re: [PATCH v3 0/4] TDX: Clean up the definitions of TDX TD ATTRIBUTES

Dear tip/tdx maintainers,

Kindly ping on this series.

It got Acked-by from KVM maintainer and Reviewed-by from other folks. 
There is one comment from Binbin on tdx_attributes[]. What's your 
preference on it? Would you consider applying this series and leave that 
comment to a separate patch or expect a next version of this series with 
that comment addressed?

On 7/15/2025 5:13 PM, Xiaoyao Li wrote:
> The main purpose of this series was to remove redundant macros between
> core TDX and KVM, along with a typo fix. They were implemented as patch1
> and patch2.
>
> During the review of v1 and v2, there was encouragement to refine the
> names of the macros related to TD attributes to clarify their scope.
> Thus patch3 and patch 4 are added. 
> Discussion details can be found in previrous versions.
> 
> 
> Changes in v3:
>   - use the changelog provided by Rick for patch 1;
>   - collect Reviewed-by on patch 4;
>   - Add patch 3;
> 
> v2: https://lore.kernel.org/all/20250711132620.262334-1-xiaoyao.li@intel.com/
> Changes in v2:
>   - collect Reviewed-by;
>   - Explains the impact of the change in patch 1 changelog;
>   - Add patch 3.
> 
> v1: https://lore.kernel.org/all/20250708080314.43081-1-xiaoyao.li@intel.com/
> 
> Xiaoyao Li (4):
>    x86/tdx: Fix the typo in TDX_ATTR_MIGRTABLE
>    KVM: TDX: Remove redundant definitions of TDX_TD_ATTR_*
>    x86/tdx: Rename TDX_ATTR_* to TDX_TD_ATTR_*
>    KVM: TDX: Rename KVM_SUPPORTED_TD_ATTRS to KVM_SUPPORTED_TDX_TD_ATTRS
> 
>   arch/x86/coco/tdx/debug.c         | 26 ++++++++--------
>   arch/x86/coco/tdx/tdx.c           |  8 ++---
>   arch/x86/include/asm/shared/tdx.h | 50 +++++++++++++++----------------
>   arch/x86/kvm/vmx/tdx.c            |  4 +--
>   arch/x86/kvm/vmx/tdx_arch.h       |  6 ----
>   5 files changed, 44 insertions(+), 50 deletions(-)
>