linux-kernel - Re: [PATCH 23/38] arm64: dts: mediatek: mt7986a: Fix PCI-Express T-PHY node address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <947b1c19-e218-4478-bb9e-8b6174815f05@gmail.com>
Date: Fri, 12 Sep 2025 16:12:55 +0200
From: Matthias Brugger <matthias.bgg@...il.com>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
 linux-mediatek@...ts.infradead.org, robh@...nel.org
Cc: herbert@...dor.apana.org.au, davem@...emloft.net, krzk+dt@...nel.org,
 conor+dt@...nel.org, chunkuang.hu@...nel.org, p.zabel@...gutronix.de,
 airlied@...il.com, simona@...ll.ch, maarten.lankhorst@...ux.intel.com,
 mripard@...nel.org, tzimmermann@...e.de, jassisinghbrar@...il.com,
 mchehab@...nel.org, chunfeng.yun@...iatek.com, vkoul@...nel.org,
 kishon@...nel.org, sean.wang@...nel.org, linus.walleij@...aro.org,
 lgirdwood@...il.com, broonie@...nel.org, andersson@...nel.org,
 mathieu.poirier@...aro.org, daniel.lezcano@...aro.org, tglx@...utronix.de,
 atenart@...nel.org, jitao.shi@...iatek.com, ck.hu@...iatek.com,
 houlong.wei@...iatek.com, kyrie.wu@...iatek.corp-partner.google.com,
 andy.teng@...iatek.com, tinghan.shen@...iatek.com, jiaxin.yu@...iatek.com,
 shane.chien@...iatek.com, olivia.wen@...iatek.com, granquet@...libre.com,
 eugen.hristev@...aro.org, arnd@...db.de, sam.shih@...iatek.com,
 jieyy.yang@...iatek.com, frank-w@...lic-files.de, mwalle@...nel.org,
 fparent@...libre.com, linux-crypto@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 dri-devel@...ts.freedesktop.org, linux-media@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-phy@...ts.infradead.org,
 linux-gpio@...r.kernel.org, linux-remoteproc@...r.kernel.org,
 linux-sound@...r.kernel.org
Subject: Re: [PATCH 23/38] arm64: dts: mediatek: mt7986a: Fix PCI-Express
 T-PHY node address



On 24/07/2025 10:38, AngeloGioacchino Del Regno wrote:
> The PCIe TPHY is under the soc bus, which provides MMIO, and all
> nodes under that must use the bus, otherwise those would clearly
> be out of place.
> 
> Add ranges to the PCIe tphy and assign the address to the main
> node to silence a dtbs_check warning, and fix the children to
> use the MMIO range of t-phy.
> 
> Fixes: 963c3b0c47ec ("arm64: dts: mediatek: fix t-phy unit name")
> Fixes: 918aed7abd2d ("arm64: dts: mt7986: add pcie related device nodes")
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>

Applied, thanks

> ---
>   arch/arm64/boot/dts/mediatek/mt7986a.dtsi | 12 ++++++------
>   1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt7986a.dtsi b/arch/arm64/boot/dts/mediatek/mt7986a.dtsi
> index 559990dcd1d1..3211905b6f86 100644
> --- a/arch/arm64/boot/dts/mediatek/mt7986a.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt7986a.dtsi
> @@ -428,16 +428,16 @@ pcie_intc: interrupt-controller {
>   			};
>   		};
>   
> -		pcie_phy: t-phy {
> +		pcie_phy: t-phy@...00000 {
>   			compatible = "mediatek,mt7986-tphy",
>   				     "mediatek,generic-tphy-v2";
> -			ranges;
> -			#address-cells = <2>;
> -			#size-cells = <2>;
> +			ranges = <0 0 0x11c00000 0x20000>;
> +			#address-cells = <1>;
> +			#size-cells = <1>;
>   			status = "disabled";
>   
> -			pcie_port: pcie-phy@...00000 {
> -				reg = <0 0x11c00000 0 0x20000>;
> +			pcie_port: pcie-phy@0 {
> +				reg = <0 0x20000>;
>   				clocks = <&clk40m>;
>   				clock-names = "ref";
>   				#phy-cells = <1>;