linux-kernel - Re: [PATCH 30/38] arm64: dts: mediatek: pumpkin-common: Fix pinctrl node names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52a54697-4b42-4c39-ae42-ae03b4231acc@gmail.com>
Date: Fri, 12 Sep 2025 16:18:36 +0200
From: Matthias Brugger <matthias.bgg@...il.com>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
 linux-mediatek@...ts.infradead.org, robh@...nel.org
Cc: herbert@...dor.apana.org.au, davem@...emloft.net, krzk+dt@...nel.org,
 conor+dt@...nel.org, chunkuang.hu@...nel.org, p.zabel@...gutronix.de,
 airlied@...il.com, simona@...ll.ch, maarten.lankhorst@...ux.intel.com,
 mripard@...nel.org, tzimmermann@...e.de, jassisinghbrar@...il.com,
 mchehab@...nel.org, chunfeng.yun@...iatek.com, vkoul@...nel.org,
 kishon@...nel.org, sean.wang@...nel.org, linus.walleij@...aro.org,
 lgirdwood@...il.com, broonie@...nel.org, andersson@...nel.org,
 mathieu.poirier@...aro.org, daniel.lezcano@...aro.org, tglx@...utronix.de,
 atenart@...nel.org, jitao.shi@...iatek.com, ck.hu@...iatek.com,
 houlong.wei@...iatek.com, kyrie.wu@...iatek.corp-partner.google.com,
 andy.teng@...iatek.com, tinghan.shen@...iatek.com, jiaxin.yu@...iatek.com,
 shane.chien@...iatek.com, olivia.wen@...iatek.com, granquet@...libre.com,
 eugen.hristev@...aro.org, arnd@...db.de, sam.shih@...iatek.com,
 jieyy.yang@...iatek.com, frank-w@...lic-files.de, mwalle@...nel.org,
 fparent@...libre.com, linux-crypto@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 dri-devel@...ts.freedesktop.org, linux-media@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-phy@...ts.infradead.org,
 linux-gpio@...r.kernel.org, linux-remoteproc@...r.kernel.org,
 linux-sound@...r.kernel.org
Subject: Re: [PATCH 30/38] arm64: dts: mediatek: pumpkin-common: Fix pinctrl
 node names



On 24/07/2025 10:39, AngeloGioacchino Del Regno wrote:
> Fix the pinctrl node names to adhere to the bindings, as the main
> pin node is supposed to be named like "uart0-pins" and the pinmux
> node named like "pins-bus".
> 
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>

Applied, thanks

> ---
>   .../boot/dts/mediatek/pumpkin-common.dtsi      | 18 +++++++++---------
>   1 file changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/mediatek/pumpkin-common.dtsi b/arch/arm64/boot/dts/mediatek/pumpkin-common.dtsi
> index a356db5fcc5f..805fb82138a8 100644
> --- a/arch/arm64/boot/dts/mediatek/pumpkin-common.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/pumpkin-common.dtsi
> @@ -198,8 +198,8 @@ &usb_phy {
>   };
>   
>   &pio {
> -	gpio_keys_default: gpiodefault {
> -		pins_cmd_dat {
> +	gpio_keys_default: gpio-keys-pins {
> +		pins-cmd-dat {
>   			pinmux = <MT8516_PIN_42_KPCOL0__FUNC_GPIO42>,
>   				 <MT8516_PIN_43_KPCOL1__FUNC_GPIO43>;
>   			bias-pull-up;
> @@ -207,7 +207,7 @@ pins_cmd_dat {
>   		};
>   	};
>   
> -	i2c0_pins_a: i2c0 {
> +	i2c0_pins_a: i2c0-pins {
>   		pins1 {
>   			pinmux = <MT8516_PIN_58_SDA0__FUNC_SDA0_0>,
>   				 <MT8516_PIN_59_SCL0__FUNC_SCL0_0>;
> @@ -215,7 +215,7 @@ pins1 {
>   		};
>   	};
>   
> -	i2c2_pins_a: i2c2 {
> +	i2c2_pins_a: i2c2-pins {
>   		pins1 {
>   			pinmux = <MT8516_PIN_60_SDA2__FUNC_SDA2_0>,
>   				 <MT8516_PIN_61_SCL2__FUNC_SCL2_0>;
> @@ -223,21 +223,21 @@ pins1 {
>   		};
>   	};
>   
> -	tca6416_pins: pinmux_tca6416_pins {
> -		gpio_mux_rst_n_pin {
> +	tca6416_pins: tca6416-pins {
> +		pins-mux-rstn {
>   			pinmux = <MT8516_PIN_65_UTXD1__FUNC_GPIO65>;
>   			output-high;
>   		};
>   
> -		gpio_mux_int_n_pin {
> +		pins-mux-intn {
>   			pinmux = <MT8516_PIN_64_URXD1__FUNC_GPIO64>;
>   			input-enable;
>   			bias-pull-up;
>   		};
>   	};
>   
> -	ethernet_pins_default: ethernet {
> -		pins_ethernet {
> +	ethernet_pins_default: ethernet-pins {
> +		pins-eth {
>   			pinmux = <MT8516_PIN_0_EINT0__FUNC_EXT_TXD0>,
>   				 <MT8516_PIN_1_EINT1__FUNC_EXT_TXD1>,
>   				 <MT8516_PIN_5_EINT5__FUNC_EXT_RXER>,