[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <175768614846.1334101.790430136214109294.robh@kernel.org>
Date: Fri, 12 Sep 2025 09:23:55 -0500
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Stefan Binding <sbinding@...nsource.cirrus.com>
Cc: devicetree@...r.kernel.org, Krzysztof Kozlowski <krzk+dt@...nel.org>,
Mark Brown <broonie@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
linux-kernel@...r.kernel.org, patches@...nsource.cirrus.com,
linux-sound@...r.kernel.org
Subject: Re: [PATCH v1 1/2] ASoC: dt-bindings: cirrus,cs35l41: Document the
cirrus,subsystem-id property
On Fri, 12 Sep 2025 11:45:37 +0100, Stefan Binding wrote:
> Add new property: cirrus,subsystem-id
> This new property is used to uniquely identify the system if device
> tree is used, to allow the driver to select the correct firmware and
> tuning for the system.
>
> Signed-off-by: Stefan Binding <sbinding@...nsource.cirrus.com>
> ---
> Documentation/devicetree/bindings/sound/cirrus,cs35l41.yaml | 6 ++++++
> 1 file changed, 6 insertions(+)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/sound/cirrus,cs35l41.yaml: cirrus,subsystem-id: missing type definition
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/sound/cirrus,cs35l41.yaml: properties:cirrus,subsystem-id:type: 'string' is not one of ['boolean', 'object']
from schema $id: http://devicetree.org/meta-schemas/core.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/sound/cirrus,cs35l41.yaml: properties:cirrus,subsystem-id:type: 'boolean' was expected
hint: A vendor boolean property can use "type: boolean"
from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250912104612.361125-2-sbinding@opensource.cirrus.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
Powered by blists - more mailing lists