linux-kernel - Re: [PATCH] HID: lenovo: Use KEY_PERFORMANCE instead of ACPI's platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5q84snp-733q-o350-16ns-n2qroo550opn@xreary.bet>
Date: Fri, 12 Sep 2025 16:23:59 +0200 (CEST)
From: Jiri Kosina <jikos@...nel.org>
To: Janne Grunau <j@...nau.net>
cc: Benjamin Tissoires <bentiss@...nel.org>, 
    Vishnu Sankar <vishnuocv@...il.com>, linux-input@...r.kernel.org, 
    regressions@...ts.linux.dev, linux-kernel@...r.kernel.org, 
    stable@...r.kernel.org
Subject: Re: [PATCH] HID: lenovo: Use KEY_PERFORMANCE instead of ACPI's
 platform_profile

On Mon, 1 Sep 2025, Janne Grunau wrote:

> Commit 84c9d2a968c82 ("HID: lenovo: Support for ThinkPad-X12-TAB-1/2 Kbd
> Fn keys") added a dependency on ACPI's platform_profile. This should not
> be done for generic USB devices as this prevents using the devices on
> non ACPI devices like Apple silicon Macs and other non-ACPI arm64
> systems. An attempt to allow using platform_profile on non-ACPI systems
> was rejected in [1] and instead platform_profile was made to fail during
> init in commit dd133162c9cf ("ACPI: platform_profile: Avoid initializing
> on non-ACPI platforms").
> So remove the broken dependency and instead let's user space handle this
> keycode by sending the new KEY_PERFORMANCE. Stable backport depends on
> commit 89c5214639294 ("Input: add keycode for performance mode key").
> 
> [1]: https://lore.kernel.org/linux-acpi/CAJZ5v0icRdTSToaKbdf=MdRin4NyB2MstUVaQo8VR6-n7DkVMQ@mail.gmail.com/
> 
> Cc: regressions@...ts.linux.dev
> Cc: stable@...r.kernel.org
> Fixes: 84c9d2a968c82 ("HID: lenovo: Support for ThinkPad-X12-TAB-1/2 Kbd Fn keys")
> Signed-off-by: Janne Grunau <j@...nau.net>
> ---
>  #regzbot introduced: 84c9d2a968c82

Applied, thanks.

-- 
Jiri Kosina
SUSE Labs