linux-kernel - Re: [PATCH 1/4] drm/sti: check dma_set_coherent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250912142859.GA51602@gnbcxd0016.gnb.st.com>
Date: Fri, 12 Sep 2025 16:28:59 +0200
From: Alain Volmat <alain.volmat@...s.st.com>
To: Raphael Gallais-Pou <rgallaispou@...il.com>
CC: Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
        Maxime Ripard
	<mripard@...nel.org>,
        Thomas Zimmermann <tzimmermann@...e.de>,
        David Airlie
	<airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
        Patrice Chotard
	<patrice.chotard@...s.st.com>,
        Rob Herring <robh@...nel.org>,
        "Krzysztof
 Kozlowski" <krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>, <dri-devel@...ts.freedesktop.org>,
        <linux-kernel@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>,
        <devicetree@...r.kernel.org>
Subject: Re: [PATCH 1/4] drm/sti: check dma_set_coherent_mask return value

Hi Raphael,

Thank you for this patch.

On Thu, Jul 17, 2025 at 09:15:32PM +0200, Raphael Gallais-Pou wrote:
> Return value for DMA allocation was not checked.  Check it and return
> error code in case of failing.
> 
> Signed-off-by: Raphael Gallais-Pou <rgallaispou@...il.com>
> ---
>  drivers/gpu/drm/sti/sti_drv.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/sti/sti_drv.c b/drivers/gpu/drm/sti/sti_drv.c
> index 5e9332df21df0db30f10b7a6f5a41cba85c4f7ae..42f21ab91957b38cb9aef012b6ee7f4ae1683edf 100644
> --- a/drivers/gpu/drm/sti/sti_drv.c
> +++ b/drivers/gpu/drm/sti/sti_drv.c
> @@ -234,8 +234,11 @@ static int sti_platform_probe(struct platform_device *pdev)
>  	struct device_node *node = dev->of_node;
>  	struct device_node *child_np;
>  	struct component_match *match = NULL;
> +	int ret;
>  
> -	dma_set_coherent_mask(dev, DMA_BIT_MASK(32));
> +	ret = dma_set_coherent_mask(dev, DMA_BIT_MASK(32));
> +	if (ret)
> +		return ret;
>  
>  	devm_of_platform_populate(dev);
>  
>
> -- 
> 2.50.1
> 

Acked-by: Alain Volmat <alain.volmat@...s.st.com>

Best regards
Alain