linux-kernel - Re: [PATCH 2/4] drm/sti: make use of drm_of_component

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250912143115.GB51602@gnbcxd0016.gnb.st.com>
Date: Fri, 12 Sep 2025 16:31:15 +0200
From: Alain Volmat <alain.volmat@...s.st.com>
To: Raphael Gallais-Pou <rgallaispou@...il.com>
CC: Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
        Maxime Ripard
	<mripard@...nel.org>,
        Thomas Zimmermann <tzimmermann@...e.de>,
        David Airlie
	<airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
        Patrice Chotard
	<patrice.chotard@...s.st.com>,
        Rob Herring <robh@...nel.org>,
        "Krzysztof
 Kozlowski" <krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>, <dri-devel@...ts.freedesktop.org>,
        <linux-kernel@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>,
        <devicetree@...r.kernel.org>
Subject: Re: [PATCH 2/4] drm/sti: make use of drm_of_component_probe

Hello Raphael,

Thanks for this patch.

On Thu, Jul 17, 2025 at 09:15:33PM +0200, Raphael Gallais-Pou wrote:
> Enhance the probing sequence by using the ports property of the
> display-subsystem node.
> 
> That done, it becomes possible to handle the display-substem node
> outside of the soc node within the device-tree and not have each IP
> blocks as children of the display-subsystem node.
> 
> Signed-off-by: Raphael Gallais-Pou <rgallaispou@...il.com>
> ---
>  drivers/gpu/drm/sti/sti_drv.c | 13 +------------
>  1 file changed, 1 insertion(+), 12 deletions(-)
> 
> diff --git a/drivers/gpu/drm/sti/sti_drv.c b/drivers/gpu/drm/sti/sti_drv.c
> index 42f21ab91957b38cb9aef012b6ee7f4ae1683edf..9d6a7c8fa0759c0b6fedf87169b18cff3684be46 100644
> --- a/drivers/gpu/drm/sti/sti_drv.c
> +++ b/drivers/gpu/drm/sti/sti_drv.c
> @@ -231,9 +231,6 @@ static const struct component_master_ops sti_ops = {
>  static int sti_platform_probe(struct platform_device *pdev)
>  {
>  	struct device *dev = &pdev->dev;
> -	struct device_node *node = dev->of_node;
> -	struct device_node *child_np;
> -	struct component_match *match = NULL;
>  	int ret;
>  
>  	ret = dma_set_coherent_mask(dev, DMA_BIT_MASK(32));
> @@ -242,15 +239,7 @@ static int sti_platform_probe(struct platform_device *pdev)
>  
>  	devm_of_platform_populate(dev);
>  
> -	child_np = of_get_next_available_child(node, NULL);
> -
> -	while (child_np) {
> -		drm_of_component_match_add(dev, &match, component_compare_of,
> -					   child_np);
> -		child_np = of_get_next_available_child(node, child_np);
> -	}
> -
> -	return component_master_add_with_match(dev, &sti_ops, match);
> +	return drm_of_component_probe(dev, component_compare_of, &sti_ops);
>  }
>  
>  static void sti_platform_remove(struct platform_device *pdev)
> 
> -- 
> 2.50.1
> 

Acked-by: Alain Volmat <alain.volmat@...s.st.com>

Best regards
Alain