linux-kernel - Re: [PATCH v3 3/4] mmc: remove COMPILE_TEST from MMC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <413a49f5-91f3-4334-9128-29297293f953@app.fastmail.com>
Date: Fri, 12 Sep 2025 16:50:38 +0200
From: "Arnd Bergmann" <arnd@...db.de>
To: "Mikko Rapeli" <mikko.rapeli@...aro.org>,
 "linux-mmc @ vger . kernel . org" <linux-mmc@...r.kernel.org>
Cc: "Ulf Hansson" <ulf.hansson@...aro.org>,
 Heiko Stübner <heiko@...ech.de>,
 linux-kernel@...r.kernel.org, "Adrian Hunter" <adrian.hunter@...el.com>,
 "Victor Shih" <victor.shih@...esyslogic.com.tw>,
 "Ben Chuang" <ben.chuang@...esyslogic.com.tw>,
 "Geert Uytterhoeven" <geert+renesas@...der.be>,
 "AngeloGioacchino Del Regno" <angelogioacchino.delregno@...labora.com>,
 "Yixun Lan" <dlan@...too.org>, "Binbin Zhou" <zhoubinbin@...ngson.cn>
Subject: Re: [PATCH v3 3/4] mmc: remove COMPILE_TEST from MMC_LOONGSON2

On Fri, Sep 12, 2025, at 16:22, Mikko Rapeli wrote:
> It fails to link due to undeclared dependency
> to regmap which is not enabled for COMPILE_TEST:
>
> ERROR: modpost: "__devm_regmap_init_mmio_clk"
> [drivers/mmc/host/loongson2-mmc.ko] undefined!

Nice catch! I assume my normal randconfig builds never
run into this because there is always something selecting
REGMAP_MMIO.

>  config MMC_LOONGSON2
>  	tristate "Loongson-2K SD/SDIO/eMMC Host Interface support"
> -	depends on LOONGARCH || COMPILE_TEST
> +	depends on LOONGARCH
>  	depends on HAS_DMA

I would instead add 'select REGMAP_MMIO' here, which is what
we do for other drivers using this.

     Arnd