linux-kernel - 回复: [v2 2/3] dt-bindings: pinctrl: Add cix,sky1-pinctrl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <PUZPR06MB5887D3C4EF7861525F174377EF08A@PUZPR06MB5887.apcprd06.prod.outlook.com>
Date: Fri, 12 Sep 2025 15:23:06 +0000
From: Gary Yang <gary.yang@...tech.com>
To: "Rob Herring (Arm)" <robh@...nel.org>
CC: "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	cix-kernel-upstream <cix-kernel-upstream@...tech.com>, "krzk+dt@...nel.org"
	<krzk+dt@...nel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "conor+dt@...nel.org" <conor+dt@...nel.org>,
	"linus.walleij@...aro.org" <linus.walleij@...aro.org>,
	"linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>
Subject:
 回复: [v2 2/3] dt-bindings: pinctrl: Add cix,sky1-pinctrl

Hi Rob,

Thanks for your comments

> 
> On Fri, 12 Sep 2025 14:06:49 +0800, Gary Yang wrote:
> > The pin-controller is used to control the Soc pins.
> > There are two pin-controllers on Cix Sky1 platform.
> > One is used under S0 state, the other is used under
> > S5 state.
> >
> > Signed-off-by: Gary Yang <gary.yang@...tech.com>
> > ---
> >  .../bindings/pinctrl/cix,sky1-pinctrl.yaml    | 85 +++++++++++++++++++
> >  1 file changed, 85 insertions(+)
> >  create mode 100644
> > Documentation/devicetree/bindings/pinctrl/cix,sky1-pinctrl.yaml
> >
> 
> My bot found errors running 'make dt_binding_check' on your patch:
> 
> yamllint warnings/errors:
> 
> dtschema/dtc warnings/errors:
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pi
> nctrl/cix,sky1-pinctrl.example.dtb: wifi-vbat-gpio-pins: pins-wifi-vbat-gpio:
> {'pinmux': [2816], 'bias-pull-up': True, 'drive-strength': 4} is not of type 'array'
>         from schema $id:
> http://devicetree.org/schemas/gpio/gpio-consumer.yaml#
> 
> doc reference errors (make refcheckdocs):
> 
> See
> https://patchwork.ozlabs.org/project/devicetree-bindings/patch/2025091206
> 0650.2180691-3-gary.yang@...tech.com
> 
> The base for the series is generally the latest rc1. A different dependency
> should be noted in *this* patch.
> 
> If you already ran 'make dt_binding_check' and didn't see the above error(s),
> then make sure 'yamllint' is installed and dt-schema is up to
> date:
> 
> pip3 install dtschema --upgrade
> 
> Please check and re-submit after running the above command yourself. Note
> that DT_SCHEMA_FILES can be set to your schema file to speed up checking
> your schema. However, it must be unset to test all examples with your schema.

As we know, must execute three commands before submit patches:
1) make O=$OUTKNL dt_binding_check DT_SCHEMA_FILES=pinctrl/cix,sky1-pinctrl.yaml
2) make CHECK_DTBS=y W=1 cix/sky1-orion-o6.dtb
3) ./scripts/checkpatch.pl 000*.patch
We don't submit any patch until no error or unexpected warning when execute three commands above.

As your suggestion, execute first command again after upgrade dtschema. But I don't see any error.
See more details as following:
gary@...y-System-Product-Name:~/workspace/upstream/kernel_upstream$ make O=$OUTKNL dt_binding_check DT_SCHEMA_FILES=pinctrl/cix,sky1-pinctrl.yaml
  SCHEMA  Documentation/devicetree/bindings/processed-schema.json
  CHKDT   ./Documentation/devicetree/bindings
  LINT    ./Documentation/devicetree/bindings
  DTEX    Documentation/devicetree/bindings/pinctrl/cix,sky1-pinctrl.example.dts
  DTC [C] Documentation/devicetree/bindings/pinctrl/cix,sky1-pinctrl.example.dtb

If I misunderstand or miss any information, please kindly remind me. 
Thanks

Best wishes
Gary