linux-kernel - Re: [PATCH v19 0/6] Introduction of a remoteproc tee to load signed firmware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <cc53b15e-f0a4-413d-95cb-174996344d64@foss.st.com>
Date: Fri, 12 Sep 2025 18:03:50 +0200
From: Arnaud POULIQUEN <arnaud.pouliquen@...s.st.com>
To: Bjorn Andersson <andersson@...nel.org>,
        Mathieu Poirier
	<mathieu.poirier@...aro.org>,
        Jens Wiklander <jens.wiklander@...aro.org>,
        Rob
 Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor
 Dooley <conor+dt@...nel.org>
CC: <linux-stm32@...md-mailman.stormreply.com>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-remoteproc@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <op-tee@...ts.trustedfirmware.org>, <devicetree@...r.kernel.org>
Subject: Re: [PATCH v19 0/6] Introduction of a remoteproc tee to load signed
 firmware

Hello BJorn, Mathieu,

Do you think, you could find time to review this series before the
next merge window.

Regarding the discussion between Harshal and Sumit, I did not notice any
comments requesting immediate updates; the conversation focused more
on potential future extensions for FF-A.

Thanks and Regards,
Arnaud.

On 6/25/25 11:40, Arnaud Pouliquen wrote:
> Main updates from version V18[2]:
> - rework documentation for the release_fw ops
> - rework function documentation in remoteproc_tee.c
> - replace spinlock by mutex and generalize usage in remoteproc_tee.c
>
>
> Main updates from version V17[1]:
> - Fix:  warning: EXPORT_SYMBOL() is used, but #include <linux/export.h>
>    is missing
>
> More details are available in each patch commit message.
>
> [1]https://lore.kernel.org/linux-remoteproc/20250613091650.2337411-1-arnaud.pouliquen@foss.st.com/
> [2]https://lore.kernel.org/linux-remoteproc/20250616075530.4106090-1-arnaud.pouliquen@foss.st.com/
>
> Tested-on: commit 19272b37aa4f ("Linux 6.16-rc1")
>
> Description of the feature:
> --------------------------
> This series proposes the implementation of a remoteproc tee driver to
> communicate with a TEE trusted application responsible for authenticating
> and loading the remoteproc firmware image in an Arm secure context.
>
> 1) Principle:
>
> The remoteproc tee driver provides services to communicate with the OP-TEE
> trusted application running on the Trusted Execution Context (TEE).
> The trusted application in TEE manages the remote processor lifecycle:
>
> - authenticating and loading firmware images,
> - isolating and securing the remote processor memories,
> - supporting multi-firmware (e.g., TF-M + Zephyr on a Cortex-M33),
> - managing the start and stop of the firmware by the TEE.
>
> 2) Format of the signed image:
>
> Refer to:
> https://github.com/OP-TEE/optee_os/blob/master/ta/remoteproc/src/remoteproc_core.c#L18-L57
>
> 3) OP-TEE trusted application API:
>
> Refer to:
> https://github.com/OP-TEE/optee_os/blob/master/ta/remoteproc/include/ta_remoteproc.h
>
> 4) OP-TEE signature script
>
> Refer to:
> https://github.com/OP-TEE/optee_os/blob/master/scripts/sign_rproc_fw.py
>
> Example of usage:
> sign_rproc_fw.py --in <fw1.elf> --in <fw2.elf> --out <signed_fw.sign> --key ${OP-TEE_PATH}/keys/default.pem
>
>
> 5) Impact on User space Application
>
> No sysfs impact. The user only needs to provide the signed firmware image
> instead of the ELF image.
>
>
> For more information about the implementation, a presentation is available here
> (note that the format of the signed image has evolved between the presentation
> and the integration in OP-TEE).
>
> https://resources.linaro.org/en/resource/6c5bGvZwUAjX56fvxthxds
>
> Arnaud Pouliquen (6):
>    remoteproc: core: Introduce rproc_pa_to_va helper
>    remoteproc: Add TEE support
>    remoteproc: Introduce optional release_fw operation
>    dt-bindings: remoteproc: Add compatibility for TEE support
>    remoteproc: stm32: Create sub-functions to request shutdown and
>      release
>    remoteproc: stm32: Add support of an OP-TEE TA to load the firmware
>
>   .../bindings/remoteproc/st,stm32-rproc.yaml   |  58 +-
>   drivers/remoteproc/Kconfig                    |  10 +
>   drivers/remoteproc/Makefile                   |   1 +
>   drivers/remoteproc/remoteproc_core.c          |  52 ++
>   drivers/remoteproc/remoteproc_internal.h      |   6 +
>   drivers/remoteproc/remoteproc_tee.c           | 708 ++++++++++++++++++
>   drivers/remoteproc/stm32_rproc.c              | 139 +++-
>   include/linux/remoteproc.h                    |   6 +
>   include/linux/remoteproc_tee.h                |  87 +++
>   9 files changed, 1023 insertions(+), 44 deletions(-)
>   create mode 100644 drivers/remoteproc/remoteproc_tee.c
>   create mode 100644 include/linux/remoteproc_tee.h
>
>
> base-commit: 19272b37aa4f83ca52bdf9c16d5d81bdd1354494