linux-kernel - RE: [EXTERNAL] [PATCH v5 01/10] x86/acpi: Add a helper functions to setup and access the wakeup mailbox

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <DS3PR21MB5878CE2590AB1899D9489B7ABF08A@DS3PR21MB5878.namprd21.prod.outlook.com>
Date: Fri, 12 Sep 2025 16:43:57 +0000
From: Dexuan Cui <decui@...rosoft.com>
To: Ricardo Neri <ricardo.neri-calderon@...ux.intel.com>, "x86@...nel.org"
	<x86@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
	<conor+dt@...nel.org>, Rob Herring <robh@...nel.org>, KY Srinivasan
	<kys@...rosoft.com>, Haiyang Zhang <haiyangz@...rosoft.com>, Wei Liu
	<wei.liu@...nel.org>, Michael Kelley <mhklinux@...look.com>, "Rafael J.
 Wysocki" <rafael@...nel.org>
CC: "ssengar@...ux.microsoft.com" <ssengar@...ux.microsoft.com>, Chris Oo
	<cho@...rosoft.com>, "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>,
	"linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Ricardo Neri
	<ricardo.neri@...el.com>
Subject: RE: [EXTERNAL] [PATCH v5 01/10] x86/acpi: Add a helper functions to
 setup and access the wakeup mailbox

> From: Ricardo Neri <ricardo.neri-calderon@...ux.intel.com>
> Sent: Friday, June 27, 2025 8:35 PM
> [...]
> In preparation to move the functionality to wake secondary CPUs up out of
> the ACPI code, add two helper functions.
> 
> The function acpi_setup_mp_wakeup_mailbox() stores the physical address of
> the mailbox and updates the wakeup_secondary_cpu_64() APIC callback.
> 
> There is a slight change in behavior: now the APIC callback is updated
> before configuring CPU hotplug offline behavior. This is fine as the APIC
> callback continues to be updated unconditionally, regardless of the
> restriction on CPU offlining.
> 
> The function acpi_madt_multiproc_wakeup_mailbox() returns a pointer to the
> mailbox. Use this helper function only in the portions of the code for
> which the variable acpi_mp_wake_mailbox will be out of scope once it is
> relocated out of the ACPI directory.
> 
> The wakeup mailbox is only supported for CONFIG_X86_64 and needed only
> with
> CONFIG_SMP=y.
> 
> Signed-off-by: Ricardo Neri <ricardo.neri-calderon@...ux.intel.com>
> ---

LGTM

Reviewed-by: Dexuan Cui <decui@...rosoft.com>