linux-kernel - RE: [EXTERNAL] Re: [PATCH net-next] net: mana: Reduce waiting time if HWC not responding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <SJ2PR21MB40130FF8C3278A49A3A6C2D4CA08A@SJ2PR21MB4013.namprd21.prod.outlook.com>
Date: Fri, 12 Sep 2025 17:48:05 +0000
From: Haiyang Zhang <haiyangz@...rosoft.com>
To: Simon Horman <horms@...nel.org>, Haiyang Zhang
	<haiyangz@...ux.microsoft.com>
CC: "linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>, Dexuan Cui
	<decui@...rosoft.com>, KY Srinivasan <kys@...rosoft.com>,
	"wei.liu@...nel.org" <wei.liu@...nel.org>, "edumazet@...gle.com"
	<edumazet@...gle.com>, "davem@...emloft.net" <davem@...emloft.net>,
	"kuba@...nel.org" <kuba@...nel.org>, "pabeni@...hat.com" <pabeni@...hat.com>,
	Long Li <longli@...rosoft.com>, "ssengar@...ux.microsoft.com"
	<ssengar@...ux.microsoft.com>, "ernis@...ux.microsoft.com"
	<ernis@...ux.microsoft.com>, "dipayanroy@...ux.microsoft.com"
	<dipayanroy@...ux.microsoft.com>, Konstantin Taranov
	<kotaranov@...rosoft.com>, Shiraz Saleem <shirazsaleem@...rosoft.com>,
	"andrew+netdev@...n.ch" <andrew+netdev@...n.ch>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [EXTERNAL] Re: [PATCH net-next] net: mana: Reduce waiting time if
 HWC not responding



> -----Original Message-----
> From: Simon Horman <horms@...nel.org>
> Sent: Friday, September 12, 2025 8:29 AM
> To: Haiyang Zhang <haiyangz@...ux.microsoft.com>
> Cc: linux-hyperv@...r.kernel.org; netdev@...r.kernel.org; Haiyang Zhang
> <haiyangz@...rosoft.com>; Dexuan Cui <decui@...rosoft.com>; KY Srinivasan
> <kys@...rosoft.com>; wei.liu@...nel.org; edumazet@...gle.com;
> davem@...emloft.net; kuba@...nel.org; pabeni@...hat.com; Long Li
> <longli@...rosoft.com>; ssengar@...ux.microsoft.com;
> ernis@...ux.microsoft.com; dipayanroy@...ux.microsoft.com; Konstantin
> Taranov <kotaranov@...rosoft.com>; Shiraz Saleem
> <shirazsaleem@...rosoft.com>; andrew+netdev@...n.ch; linux-
> kernel@...r.kernel.org
> Subject: [EXTERNAL] Re: [PATCH net-next] net: mana: Reduce waiting time if
> HWC not responding
> 
> On Wed, Sep 10, 2025 at 01:57:21PM -0700, Haiyang Zhang wrote:
> > From: Haiyang Zhang <haiyangz@...rosoft.com>
> >
> > If HW Channel (HWC) is not responding, reduce the waiting time, so
> further
> > steps will fail quickly.
> > This will prevent getting stuck for a long time (30 minutes or more),
> for
> > example, during unloading while HWC is not responding.
> >
> > Signed-off-by: Haiyang Zhang <haiyangz@...rosoft.com>
> > ---
> >  drivers/net/ethernet/microsoft/mana/hw_channel.c | 7 ++++++-
> >  1 file changed, 6 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/ethernet/microsoft/mana/hw_channel.c
> b/drivers/net/ethernet/microsoft/mana/hw_channel.c
> > index ef072e24c46d..ada6c78a2bef 100644
> > --- a/drivers/net/ethernet/microsoft/mana/hw_channel.c
> > +++ b/drivers/net/ethernet/microsoft/mana/hw_channel.c
> > @@ -881,7 +881,12 @@ int mana_hwc_send_request(struct hw_channel_context
> *hwc, u32 req_len,
> >  	if (!wait_for_completion_timeout(&ctx->comp_event,
> >  					 (msecs_to_jiffies(hwc->hwc_timeout)))) {
> >  		if (hwc->hwc_timeout != 0)
> > -			dev_err(hwc->dev, "HWC: Request timed out!\n");
> > +			dev_err(hwc->dev, "HWC: Request timed out: %u ms\n",
> > +				hwc->hwc_timeout);
> > +
> > +		/* Reduce further waiting if HWC no response */
> > +		if (hwc->hwc_timeout > 1)
> > +			hwc->hwc_timeout = 1;
> 
> Hi,
> 
> Perhaps it is already the case, but I'm wondering if the configured
> value of hwc_timeout should be restored at some point.

Yes it's already the case: when the driver does reset/recovery, or gets
a timeout-value-message from the NIC, the time out value will be updated.

Thanks,
- Haiyang