linux-kernel - Re: [PATCH V3] drm/bridge: ti-sn65dsi86: Add support for DisplayPort mode with HPD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250912192356.2067099-1-john.ripple@keysight.com>
Date: Fri, 12 Sep 2025 13:23:56 -0600
From: John Ripple <john.ripple@...sight.com>
To: dianders@...omium.org
Cc: Laurent.pinchart@...asonboard.com, airlied@...il.com,
        andrzej.hajda@...el.com, blake.vermeer@...sight.com,
        dri-devel@...ts.freedesktop.org, jernej.skrabec@...il.com,
        john.ripple@...sight.com, jonas@...boo.se,
        linux-kernel@...r.kernel.org, maarten.lankhorst@...ux.intel.com,
        matt_laubhan@...sight.com, mripard@...nel.org,
        neil.armstrong@...aro.org, rfoss@...nel.org, simona@...ll.ch,
        tzimmermann@...e.de
Subject: Re: [PATCH V3] drm/bridge: ti-sn65dsi86: Add support for DisplayPort mode with HPD

Hi, 

>As I said, maybe the problem is fixed now, but at the same time there
>is something nice about the interrupt type only being specified in one
>place. ...and IIRC the device tree validator gets upset if you don't
>specify the interrupt type there, so removing it from the source code
>seems nice...

My device tree does have interrupts already specified for the node, 
so allowing the driver to use that does seem like a good idea.

> [1] https://stackoverflow.com/questions/40011799/mapping-device-tree-interrupt-flags-to-devm-request-irq

The link you sent suggests just using "0" for the flag value lets the 
device tree flags to be used. I couldn't do this because the 
IRQF_ONESHOT needed to be passed as a flag or I'd get stack traces
every time the irq was triggered. Several of the other drivers in 
drivers/gpu/drm/bridge only pass IRQ_ONESHOT so I think those might be
using the device tree flags with the oneshot flag. As far as I could
tell, only passing the oneshot flag and setting the interrupt level
high in the device tree works.