linux-kernel - Re: [PATCH 1/3] alloc_tag: use release

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJuCfpHf6shxs0A1dmRuYjjU-wU8p=tFD3BO43DTYbZ0U=rFMQ@mail.gmail.com>
Date: Fri, 12 Sep 2025 14:05:18 -0700
From: Suren Baghdasaryan <surenb@...gle.com>
To: Usama Arif <usamaarif642@...il.com>
Cc: akpm@...ux-foundation.org, kent.overstreet@...ux.dev, vbabka@...e.cz, 
	mhocko@...e.com, jackmanb@...gle.com, hannes@...xchg.org, ziy@...dia.com, 
	shakeel.butt@...ux.dev, 00107082@....com, pasha.tatashin@...een.com, 
	souravpanda@...gle.com, linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] alloc_tag: use release_pages() in the cleanup path

On Wed, Sep 10, 2025 at 1:49 PM Usama Arif <usamaarif642@...il.com> wrote:
>
>
>
> On 10/09/2025 00:34, Suren Baghdasaryan wrote:
> > When bulk-freeing an array of pages use release_pages() instead of freeing
> > them page-by-page:
> >
> > Suggested-by: Andrew Morton <akpm@...ux-foundation.org>
> > Signed-off-by: Suren Baghdasaryan <surenb@...gle.com>
> > ---
> >  lib/alloc_tag.c | 5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
> >
>
> Acked-by: Usama Arif <usamaarif642@...il.com>
>
> > diff --git a/lib/alloc_tag.c b/lib/alloc_tag.c
> > index e9b33848700a..95688c4cba7a 100644
> > --- a/lib/alloc_tag.c
> > +++ b/lib/alloc_tag.c
> > @@ -438,9 +438,10 @@ static int vm_module_tags_populate(void)
> >               if (nr < more_pages ||
> >                   vmap_pages_range(phys_end, phys_end + (nr << PAGE_SHIFT), PAGE_KERNEL,
> >                                    next_page, PAGE_SHIFT) < 0) {
> > +                     release_pages_arg arg = { .pages = next_page };
> > +
> >                       /* Clean up and error out */
> > -                     for (int i = 0; i < nr; i++)
> > -                             __free_page(next_page[i]);
> > +                     release_pages(arg, nr);
> >                       return -ENOMEM;
> >               }
> >
>
> Maybe this can be done in free_mod_tags_mem as well?

Good point. I think I will respin this patchset with your suggestions
and will include one more fix for an issue that Shakeel just reported
(see https://lore.kernel.org/all/CAJuCfpGUjaZcs1r9ADKck_Ni7f41kHaiejR01Z0bE8pG0K1uXA@mail.gmail.com/).
Thanks!
Suren.