linux-kernel - Re: [PATCH] selftests/futex: Conditionally run futex_numa

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250912214454.t0qhEqT2@linutronix.de>
Date: Fri, 12 Sep 2025 23:44:54 +0200
From: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
To: Wake Liu <wakel@...gle.com>
Cc: Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>,
	Shuah Khan <shuah@...nel.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Darren Hart <dvhart@...radead.org>,
	Davidlohr Bueso <dave@...olabs.net>,
	André Almeida <andrealmeid@...lia.com>,
	linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org
Subject: Re: [PATCH] selftests/futex: Conditionally run futex_numa_mpol test

On 2025-09-08 19:37:20 [+0800], Wake Liu wrote:
> The futex_numa_mpol test requires libnuma, which is not available on
> all platforms. When the test is not built, the run.sh script fails
> because it unconditionally tries to execute the test binary.
> 
> Check for the futex_numa_mpol executable before running it. If the
> binary is not present, print a skip message and continue.
> 
> This allows the test suite to run successfully on platforms that do
> not have libnuma and therefore do not build the futex_numa_mpol
> test.

If you skip the test, how to you compile this?
Does
	https://lore.kernel.org/all/20250818135458.F352St6W@linutronix.de/

help?

> Signed-off-by: Wake Liu <wakel@...gle.com>
> ---
>  tools/testing/selftests/futex/functional/run.sh | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/futex/functional/run.sh b/tools/testing/selftests/futex/functional/run.sh
> index 81739849f299..f3e43eb806bf 100755
> --- a/tools/testing/selftests/futex/functional/run.sh
> +++ b/tools/testing/selftests/futex/functional/run.sh
> @@ -88,4 +88,8 @@ echo
>  ./futex_priv_hash -g $COLOR
>  
>  echo
> -./futex_numa_mpol $COLOR
> +if [ -x ./futex_numa_mpol ]; then
> +    ./futex_numa_mpol $COLOR
> +else
> +    echo "SKIP: futex_numa_mpol (not built)"
> +fi

Sebastian