linux-kernel - Re: [PATCH] coresight: trbe: Use scope-based resource management in arm_trbe_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b89eda12-c930-43e8-92c0-c2e1699284f7@web.de>
Date: Fri, 12 Sep 2025 08:00:07 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Anshuman Khandual <anshuman.khandual@....com>,
 coresight@...ts.linaro.org, linux-arm-kernel@...ts.infradead.org,
 Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
 James Clark <james.clark@...aro.org>, Mike Leach <mike.leach@...aro.org>,
 Suzuki K Poulose <suzuki.poulose@....com>
Cc: kernel-janitors@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
 Leo Yan <leo.yan@....com>, Tamas Zsoldos <tamas.zsoldos@....com>
Subject: Re: [PATCH] coresight: trbe: Use scope-based resource management in
 arm_trbe_alloc_buffer()

>> Scope-based resource management became supported for some
>> programming interfaces by contributions of Peter Zijlstra on 2023-05-26.
>> See also the commit 54da6a0924311c7cf5015533991e44fb8eb12773 ("locking:
> 
> 			^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> 
> SHA ID here just needs first 12 digits not the entire string.

See also once more:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.17-rc5#n109


>> Introduce __cleanup() based infrastructure").
>>
>> * Thus use the attribute “__free(kfree)”.
>>
>> * Reduce the scopes for the local variables “buf” and “pglist”.
> 
> What is that required ?

The needed variables should be defined in a succinct way.


>> * Omit four kfree() calls accordingly.
> 
> Right.
> 
> The commit message should be re-written with little more
> context from arm_trbe_alloc_buffer(), after describing
> the new scope-based resource management.

Which background information do you miss so far?

Regards,
Markus