linux-kernel - Re: [PATCH v5 02/10] dt-bindings: clock: Add required "interconnect-cells" property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250912-nocturnal-horse-of-acumen-5b2cbd@kuoka>
Date: Fri, 12 Sep 2025 09:04:27 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Luo Jie <quic_luoj@...cinc.com>
Cc: Bjorn Andersson <andersson@...nel.org>, 
	Michael Turquette <mturquette@...libre.com>, Stephen Boyd <sboyd@...nel.org>, 
	Varadarajan Narayanan <quic_varada@...cinc.com>, Georgi Djakov <djakov@...nel.org>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Anusha Rao <quic_anusha@...cinc.com>, Manikanta Mylavarapu <quic_mmanikan@...cinc.com>, 
	Devi Priya <quic_devipriy@...cinc.com>, Philipp Zabel <p.zabel@...gutronix.de>, 
	Richard Cochran <richardcochran@...il.com>, Konrad Dybcio <konradybcio@...nel.org>, 
	Catalin Marinas <catalin.marinas@....com>, Will Deacon <will@...nel.org>, linux-arm-msm@...r.kernel.org, 
	linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org, 
	devicetree@...r.kernel.org, netdev@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, 
	quic_kkumarcs@...cinc.com, quic_linchen@...cinc.com, quic_leiwei@...cinc.com, 
	quic_pavir@...cinc.com, quic_suruchia@...cinc.com
Subject: Re: [PATCH v5 02/10] dt-bindings: clock: Add required
 "interconnect-cells" property

On Tue, Sep 09, 2025 at 09:39:11PM +0800, Luo Jie wrote:
> The Networking Subsystem (NSS) clock controller acts as both a clock
> provider and an interconnect provider. The #interconnect-cells property
> is mandatory in the Device Tree Source (DTS) to ensure that client
> drivers, such as the PPE driver, can correctly acquire ICC clocks from
> the NSS ICC provider.
> 
> Although this property is already present in the NSS CC node of the DTS
> for CMN PLL for IPQ9574 SoC which is currently supported, it was previously
> omitted from the list of required properties in the bindings documentation.
> Adding this as a required property is not expected to break the ABI for
> currently supported SoC.
> 
> Marking #interconnect-cells as required to comply with Device Tree (DT)
> binding requirements for interconnect providers.

DT bindings do not require interconnect-cells, so that's not a correct
reason. Drop them from required properties.

Best regards,
Krzysztof