linux-kernel - Re: [PATCH] gpio: of: Simplify printks with pOF format

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <998aae0b-ef64-49b6-9948-c4171cdeac70@linaro.org>
Date: Fri, 12 Sep 2025 11:35:39 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Linus Walleij <linus.walleij@...aro.org>,
 Bartosz Golaszewski <brgl@...ev.pl>, linux-gpio@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] gpio: of: Simplify printks with pOF format

On 12/09/2025 11:24, Krzysztof Kozlowski wrote:
> Print full device node name with %pOF format, so the code will be a bit
> simpler.  Code already uses pOF in other places, so this also unifies
> with the rest.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> ---
>  drivers/gpio/gpiolib-of.c | 20 +++++++++-----------
>  1 file changed, 9 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/gpio/gpiolib-of.c b/drivers/gpio/gpiolib-of.c
> index 37ab78243fab..bf17658623b9 100644
> --- a/drivers/gpio/gpiolib-of.c
> +++ b/drivers/gpio/gpiolib-of.c
> @@ -160,14 +160,12 @@ static void of_gpio_quirk_polarity(const struct device_node *np,
>  {
>  	if (active_high) {
>  		if (*flags & OF_GPIO_ACTIVE_LOW) {
> -			pr_warn("%s GPIO handle specifies active low - ignored\n",
> -				of_node_full_name(np));
> +			pr_warn("%pOF GPIO handle specifies active low - ignored\n", np);
>  			*flags &= ~OF_GPIO_ACTIVE_LOW;

Heh, I misread the docs and see now in the testing that my patch changes
the behavior. of_node_full_name() is just node name. pOF is full path.

This might be desired (more accurate warning in case many nodes share
similar name) or not...

Best regards,
Krzysztof