linux-kernel - Re: [PATCH] firmware: arm_scmi: Simplify printks with pOF format

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c5df4196-b951-4f8e-b2ca-c63fba63d1ee@linaro.org>
Date: Fri, 12 Sep 2025 11:34:53 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Sudeep Holla <sudeep.holla@....com>,
 Cristian Marussi <cristian.marussi@....com>, arm-scmi@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] firmware: arm_scmi: Simplify printks with pOF format

On 12/09/2025 11:24, Krzysztof Kozlowski wrote:
> Print full device node name with %pOF format, so the code will be a bit
> simpler.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> ---
>  drivers/firmware/arm_scmi/bus.c                | 13 ++++++-------
>  drivers/firmware/arm_scmi/transports/mailbox.c |  7 +++----
>  2 files changed, 9 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/firmware/arm_scmi/bus.c b/drivers/firmware/arm_scmi/bus.c
> index 24e59ddf85e7..c7698cfaa4e8 100644
> --- a/drivers/firmware/arm_scmi/bus.c
> +++ b/drivers/firmware/arm_scmi/bus.c
> @@ -401,8 +401,8 @@ static void scmi_device_release(struct device *dev)
>  
>  static void __scmi_device_destroy(struct scmi_device *scmi_dev)
>  {
> -	pr_debug("(%s) Destroying SCMI device '%s' for protocol 0x%x (%s)\n",
> -		 of_node_full_name(scmi_dev->dev.parent->of_node),
> +	pr_debug("(%pOF) Destroying SCMI device '%s' for protocol 0x%x (%s)\n",
> +		 scmi_dev->dev.parent->of_node,
>  		 dev_name(&scmi_dev->dev), scmi_dev->protocol_id,
>  		 scmi_dev->name);

Heh, I misread the docs and see now in the testing that my patch changes
the behavior. of_node_full_name() is just node name. pOF is full path.

This might be desired or not...

Best regards,
Krzysztof