linux-kernel - Re: [PATCH v12 00/11] Trusted Execution Environment (TEE) driver for Qualcomm TEE (QTEE)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <aMPr-sYzFDlr-R8R@sumit-X1>
Date: Fri, 12 Sep 2025 15:16:34 +0530
From: Sumit Garg <sumit.garg@...nel.org>
To: Jens Wiklander <jens.wiklander@...aro.org>,
	Bjorn Andersson <andersson@...nel.org>
Cc: Amirreza Zarrabi <amirreza.zarrabi@....qualcomm.com>,
	Konrad Dybcio <konradybcio@...nel.org>,
	Bartosz Golaszewski <bartosz.golaszewski@...aro.org>,
	Apurupa Pattapu <quic_apurupa@...cinc.com>,
	Kees Cook <kees@...nel.org>,
	"Gustavo A. R. Silva" <gustavoars@...nel.org>,
	Sumit Semwal <sumit.semwal@...aro.org>,
	Christian König <christian.koenig@....com>,
	Harshal Dev <quic_hdev@...cinc.com>, linux-arm-msm@...r.kernel.org,
	op-tee@...ts.trustedfirmware.org, linux-kernel@...r.kernel.org,
	linux-hardening@...r.kernel.org, dri-devel@...ts.freedesktop.org,
	linaro-mm-sig@...ts.linaro.org, linux-doc@...r.kernel.org,
	Neil Armstrong <neil.armstrong@...aro.org>,
	Kuldeep Singh <quic_kuldsing@...cinc.com>,
	Sumit Garg <sumit.garg@....qualcomm.com>
Subject: Re: [PATCH v12 00/11] Trusted Execution Environment (TEE) driver for
 Qualcomm TEE (QTEE)

On Fri, Sep 12, 2025 at 10:21:55AM +0200, Jens Wiklander wrote:
> Hi,
> 
> On Fri, Sep 12, 2025 at 6:07 AM Amirreza Zarrabi
> <amirreza.zarrabi@....qualcomm.com> wrote:
> >
> > This patch series introduces a Trusted Execution Environment (TEE)
> > driver for Qualcomm TEE (QTEE). QTEE enables Trusted Applications (TAs)
> > and services to run securely. It uses an object-based interface, where
> > each service is an object with sets of operations. Clients can invoke
> > these operations on objects, which can generate results, including other
> > objects. For example, an object can load a TA and return another object
> > that represents the loaded TA, allowing access to its services.
> >
> [snip]
> 
> I'm OK with the TEE patches, Sumit and I have reviewed them.
> 
> There were some minor conflicts with other patches I have in the pipe
> for this merge window, so this patchset is on top of what I have to
> avoid merge conflicts.
> 
> However, the firmware patches are for code maintained by Björn.
> Björn, how would you like to do this? Can I take them via my tree, or
> what do you suggest?

I had an offline chat with Amir about this and there is a build
dependency of QTEE driver on firmware patches in case the patches gets
applied in reverse order (first QTEE patches and then firmware ones).
So I would suggest the complete patch-set goes through Jens tree given
the very limited time we have.

Bjorn,

Would it be fine for you to provide your ack for the firmware patches?

-Sumit

> 
> It's urgent to get this patchset into linux-next if it's to make it
> for the coming merge window. Ideally, I'd like to send my pull request
> to arm-soc during this week.
> 
> Cheers,
> Jens
> 
> >
> > ---
> > Amirreza Zarrabi (11):
> >       firmware: qcom: tzmem: export shm_bridge create/delete
> >       firmware: qcom: scm: add support for object invocation
> >       tee: allow a driver to allocate a tee_device without a pool
> >       tee: add close_context to TEE driver operation
> >       tee: add TEE_IOCTL_PARAM_ATTR_TYPE_UBUF
> >       tee: add TEE_IOCTL_PARAM_ATTR_TYPE_OBJREF
> >       tee: increase TEE_MAX_ARG_SIZE to 4096
> >       tee: add Qualcomm TEE driver
> >       tee: qcom: add primordial object
> >       tee: qcom: enable TEE_IOC_SHM_ALLOC ioctl
> >       Documentation: tee: Add Qualcomm TEE driver
> >
> >  Documentation/tee/index.rst              |   1 +
> >  Documentation/tee/qtee.rst               |  96 ++++
> >  MAINTAINERS                              |   7 +
> >  drivers/firmware/qcom/qcom_scm.c         | 119 ++++
> >  drivers/firmware/qcom/qcom_scm.h         |   7 +
> >  drivers/firmware/qcom/qcom_tzmem.c       |  63 ++-
> >  drivers/tee/Kconfig                      |   1 +
> >  drivers/tee/Makefile                     |   1 +
> >  drivers/tee/qcomtee/Kconfig              |  12 +
> >  drivers/tee/qcomtee/Makefile             |   9 +
> >  drivers/tee/qcomtee/async.c              | 182 ++++++
> >  drivers/tee/qcomtee/call.c               | 820 +++++++++++++++++++++++++++
> >  drivers/tee/qcomtee/core.c               | 915 +++++++++++++++++++++++++++++++
> >  drivers/tee/qcomtee/mem_obj.c            | 169 ++++++
> >  drivers/tee/qcomtee/primordial_obj.c     | 113 ++++
> >  drivers/tee/qcomtee/qcomtee.h            | 185 +++++++
> >  drivers/tee/qcomtee/qcomtee_msg.h        | 304 ++++++++++
> >  drivers/tee/qcomtee/qcomtee_object.h     | 316 +++++++++++
> >  drivers/tee/qcomtee/shm.c                | 150 +++++
> >  drivers/tee/qcomtee/user_obj.c           | 692 +++++++++++++++++++++++
> >  drivers/tee/tee_core.c                   | 127 ++++-
> >  drivers/tee/tee_private.h                |   6 -
> >  include/linux/firmware/qcom/qcom_scm.h   |   6 +
> >  include/linux/firmware/qcom/qcom_tzmem.h |  15 +
> >  include/linux/tee_core.h                 |  54 +-
> >  include/linux/tee_drv.h                  |  12 +
> >  include/uapi/linux/tee.h                 |  56 +-
> >  27 files changed, 4410 insertions(+), 28 deletions(-)
> > ---
> > base-commit: 8b8aefa5a5c7d4a65883e5653cf12f94c0b68dbf
> > change-id: 20241202-qcom-tee-using-tee-ss-without-mem-obj-362c66340527
> >
> > Best regards,
> > --
> > Amirreza Zarrabi <amirreza.zarrabi@....qualcomm.com>
> >