| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <CADrjBPqT8GORaMReQwMGUV+Lrh-njhk_giD2gQUPJRRuSz4XNw@mail.gmail.com>
Date: Fri, 12 Sep 2025 11:47:21 +0100
From: Peter Griffin <peter.griffin@...aro.org>
To: t.antoine@...ouvain.be
Cc: Sebastian Reichel <sre@...nel.org>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
Dimitri Fedrau <dima.fedrau@...il.com>, Catalin Marinas <catalin.marinas@....com>,
Will Deacon <will@...nel.org>, André Draszik <andre.draszik@...aro.org>,
Tudor Ambarus <tudor.ambarus@...aro.org>, Alim Akhtar <alim.akhtar@...sung.com>,
linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org,
devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-samsung-soc@...r.kernel.org
Subject: Re: [PATCH v5 4/4] arm64: dts: exynos: google: add Maxim MAX77759 Fuel-gauge
On Mon, 4 Aug 2025 at 15:25, Thomas Antoine via B4 Relay
<devnull+t.antoine.uclouvain.be@...nel.org> wrote:
>
> From: Thomas Antoine <t.antoine@...ouvain.be>
>
> Add the node for the Maxim MAX77759 fuel gauge as a slave of the i2c.
>
> The TODO is still applicable given there are other slaves on the
> bus (e.g. PCA9468, other MAX77759 functions and the MAX20339 OVP).
>
> For the device specific values (full design capacity and terminal
> current), the device should check an EEPROM at address 0x50 of the
> hsi2c_8 for a battery id stored in register 0x17. A set of parameters
> for the initialization of the fuel gauge should be chosen based on
> this id. Those sets are defined here:
>
> Link: https://android.googlesource.com/kernel/gs/+/refs/heads/android-gs-raviole-5.10-android15/arch/arm64/boot/dts/google/gs101-oriole-battery-data.dtsi
> Link: https://android.googlesource.com/kernel/gs/+/refs/heads/android-gs-raviole-5.10-android15/arch/arm64/boot/dts/google/gs101-raven-battery-data.dtsi
>
> This does not seem to be a standard pattern in the kernel currently
> so it is not implemented. Values observed on tested devices are
> instead used. The driver or the devicetree should be should be
> extended in the future to take versions into account.
>
> The pinctrl name follows the convention proposed in
> Link: https://lore.kernel.org/all/20250524-b4-max77759-mfd-dts-v2-2-b479542eb97d@linaro.org/
>
> Signed-off-by: Thomas Antoine <t.antoine@...ouvain.be>
> ---
This needs rebasing now to apply. With Andre's feedback addressed
Reviewed-by: Peter Griffin <peter.griffin@...aro.org>
> arch/arm64/boot/dts/exynos/google/gs101-oriole.dts | 10 ++++++++
> .../boot/dts/exynos/google/gs101-pixel-common.dtsi | 30 ++++++++++++++++++++++
> arch/arm64/boot/dts/exynos/google/gs101-raven.dts | 11 ++++++++
> 3 files changed, 51 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/exynos/google/gs101-oriole.dts b/arch/arm64/boot/dts/exynos/google/gs101-oriole.dts
> index 8df42bedbc036b5e97f6238d64820370043ffef2..18d147f6ea4a1a76c375996557349c866b9dad72 100644
> --- a/arch/arm64/boot/dts/exynos/google/gs101-oriole.dts
> +++ b/arch/arm64/boot/dts/exynos/google/gs101-oriole.dts
> @@ -13,6 +13,12 @@
> / {
> model = "Oriole";
> compatible = "google,gs101-oriole", "google,gs101";
> +
> + battery: battery {
> + compatible = "simple-battery";
> + charge-full-design-microamp-hours = <4524000>;
> + charge-term-current-microamp = <45000>;
> + };
> };
>
> &cont_splash_mem {
> @@ -27,3 +33,7 @@ &framebuffer0 {
> format = "a8r8g8b8";
> status = "okay";
> };
> +
> +&fuel_gauge {
> + monitored-battery = <&battery>;
> +};
> diff --git a/arch/arm64/boot/dts/exynos/google/gs101-pixel-common.dtsi b/arch/arm64/boot/dts/exynos/google/gs101-pixel-common.dtsi
> index d6ddcc13f7b20c6dfbe92e86abafe965870d0c78..3362ad89ef6bacb7349259cf9e14452193ff7361 100644
> --- a/arch/arm64/boot/dts/exynos/google/gs101-pixel-common.dtsi
> +++ b/arch/arm64/boot/dts/exynos/google/gs101-pixel-common.dtsi
> @@ -10,6 +10,7 @@
>
> #include <dt-bindings/gpio/gpio.h>
> #include <dt-bindings/input/input.h>
> +#include <dt-bindings/interrupt-controller/irq.h>
> #include <dt-bindings/usb/pd.h>
> #include "gs101-pinctrl.h"
> #include "gs101.dtsi"
> @@ -99,6 +100,16 @@ &hsi2c_8 {
> eeprom: eeprom@50 {
> compatible = "atmel,24c08";
> reg = <0x50>;
> +
> + nvmem-layout {
> + compatible = "fixed-layout";
> + #address-cells = <1>;
> + #size-cells = <1>;
> +
> + fg_state: fgstate@42 {
> + reg = <0x42 0x17>;
> + };
> + };
> };
> };
>
> @@ -188,6 +199,18 @@ usbc0_role_sw: endpoint {
> };
> };
> };
> +
> + fuel_gauge: fuel-gauge@36 {
> + compatible = "maxim,max77759-fg";
> + reg = <0x36>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&if_pmic_fg_int>;
> + interrupt-parent = <&gpa9>;
> + interrupts = <3 IRQ_TYPE_LEVEL_LOW>;
> + shunt-resistor-micro-ohms = <5000>;
> + nvmem-cell-names = "fg_state";
> + nvmem-cells = <&fg_state>;
> + };
> };
>
> &pinctrl_far_alive {
> @@ -214,6 +237,13 @@ typec_int: typec-int-pins {
> };
>
> &pinctrl_gpio_alive {
> + if_pmic_fg_int: if-pmic-fg-int-pins {
> + samsung,pins = "gpa9-3";
> + samsung,pin-function = <GS101_PIN_FUNC_EINT>;
> + samsung,pin-pud = <GS101_PIN_PULL_UP>;
> + samsung,pin-drv = <GS101_PIN_DRV_2_5_MA>;
> + };
> +
> key_power: key-power-pins {
> samsung,pins = "gpa10-1";
> samsung,pin-function = <GS101_PIN_FUNC_EINT>;
> diff --git a/arch/arm64/boot/dts/exynos/google/gs101-raven.dts b/arch/arm64/boot/dts/exynos/google/gs101-raven.dts
> index 1e7e6b34b8649bc700a745c579a0268f0f6a9524..f91800879ea94b8fb0008c5e1f828072cabc1ac7 100644
> --- a/arch/arm64/boot/dts/exynos/google/gs101-raven.dts
> +++ b/arch/arm64/boot/dts/exynos/google/gs101-raven.dts
> @@ -13,6 +13,13 @@
> / {
> model = "Raven";
> compatible = "google,gs101-raven", "google,gs101";
> +
> + battery: battery {
> + compatible = "simple-battery";
> +
> + charge-full-design-microamp-hours = <4904000>;
> + charge-term-current-microamp = <49000>;
> + };
> };
>
> &cont_splash_mem {
> @@ -27,3 +34,7 @@ &framebuffer0 {
> format = "a8r8g8b8";
> status = "okay";
> };
> +
> +&fuel_gauge {
> + monitored-battery = <&battery>;
> +};
>
> --
> 2.50.1
>
>
Powered by blists - more mailing lists