linux-kernel - Re: [PATCH v2] crypto: chelsio - Use library to prepare HMAC keys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aMTy9foi5kHRzYei@gondor.apana.org.au>
Date: Sat, 13 Sep 2025 12:28:37 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: Eric Biggers <ebiggers@...nel.org>
Cc: linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org,
	ardb@...nel.org, Jason@...c4.com, ayush.sawal@...lsio.com,
	ebiggers@...nel.org, giovanni.cabiddu@...el.com
Subject: Re: [PATCH v2] crypto: chelsio - Use library to prepare HMAC keys

Eric Biggers <ebiggers@...nel.org> wrote:
> To prepare HMAC keys, just use the library functions instead of
> crypto_shash.  This is much simpler, avoids depending on the fragile
> export_core and import_core methods, and is faster too.
> 
> Signed-off-by: Eric Biggers <ebiggers@...nel.org>
> ---
> 
> This is the same diff as v1, but with an updated commit message and now
> targeting cryptodev/master instead of libcrypto-fixes.  Since I'm going
> with
> https://lore.kernel.org/r/20250901165013.48649-1-ebiggers@kernel.org/ to
> fix the reported regression instead, this patch is now "just" a library
> conversion and not a fix per se.  If needed I'd be glad to take this
> through libcrypto-next instead, but usually these conversions have been
> going through subsystem trees (which is Herbert's in this case).
> 
> drivers/crypto/chelsio/Kconfig       |   6 +-
> drivers/crypto/chelsio/chcr_algo.c   | 259 +++++++--------------------
> drivers/crypto/chelsio/chcr_crypto.h |   1 -
> 3 files changed, 63 insertions(+), 203 deletions(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt