linux-kernel - Re: [PATCH] crypto: qat - Replace kzalloc() + copy_from_user() with memdup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aMTzlemW_w2ZtjS9@gondor.apana.org.au>
Date: Sat, 13 Sep 2025 12:31:17 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: Thorsten Blum <thorsten.blum@...ux.dev>
Cc: Giovanni Cabiddu <giovanni.cabiddu@...el.com>,
	"David S. Miller" <davem@...emloft.net>,
	Peter Zijlstra <peterz@...radead.org>,
	Greg KH <gregkh@...uxfoundation.org>, qat-linux@...el.com,
	linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] crypto: qat - Replace kzalloc() + copy_from_user() with
 memdup_user()

On Fri, Sep 05, 2025 at 06:39:11PM +0200, Thorsten Blum wrote:
> Replace kzalloc() followed by copy_from_user() with memdup_user() to
> improve and simplify adf_ctl_alloc_resources(). memdup_user() returns
> either -ENOMEM or -EFAULT (instead of -EIO) if an error occurs.
> 
> Remove the unnecessary device id initialization, since memdup_user()
> (like copy_from_user()) immediately overwrites it.
> 
> No functional changes intended other than returning the more idiomatic
> error code -EFAULT.
> 
> Signed-off-by: Thorsten Blum <thorsten.blum@...ux.dev>
> ---
>  drivers/crypto/intel/qat/qat_common/adf_ctl_drv.c | 13 +++----------
>  1 file changed, 3 insertions(+), 10 deletions(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt