linux-kernel - Re: [PATCH] xfs: extend removed sysctls table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250913002304.GR8117@frogsfrogsfrogs>
Date: Fri, 12 Sep 2025 17:23:04 -0700
From: "Darrick J. Wong" <djwong@...nel.org>
To: Bagas Sanjaya <bagasdotme@...il.com>
Cc: Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Linux Documentation <linux-doc@...r.kernel.org>,
	Linux XFS <linux-xfs@...r.kernel.org>,
	David Chinner <david@...morbit.com>,
	Carlos Maiolino <cem@...nel.org>, Jonathan Corbet <corbet@....net>,
	Charles Han <hanchunchao@...pur.com>,
	Stephen Rothwell <sfr@...b.auug.org.au>
Subject: Re: [PATCH] xfs: extend removed sysctls table

On Tue, Sep 09, 2025 at 07:04:31AM +0700, Bagas Sanjaya wrote:
> Commit 21d59d00221e4e ("xfs: remove deprecated sysctl knobs") moves
> recently-removed sysctls to the removed sysctls table but fails to
> extend the table, hence triggering Sphinx warning:
> 
> Documentation/admin-guide/xfs.rst:365: ERROR: Malformed table.
> Text in column margin in table line 8.
> 
> =============================   =======
>   Name                          Removed
> =============================   =======
>   fs.xfs.xfsbufd_centisec       v4.0
>   fs.xfs.age_buffer_centisecs   v4.0
>   fs.xfs.irix_symlink_mode      v6.18
>   fs.xfs.irix_sgid_inherit      v6.18
>   fs.xfs.speculative_cow_prealloc_lifetime      v6.18
> =============================   ======= [docutils]
> 
> Extend "Name" column of the table to fit the now-longest sysctl, which
> is fs.xfs.speculative_cow_prealloc_lifetime.
> 
> Fixes: 21d59d00221e ("xfs: remove deprecated sysctl knobs")
> Reported-by: Stephen Rothwell <sfr@...b.auug.org.au>
> Closes: https://lore.kernel.org/linux-next/20250908180406.32124fb7@canb.auug.org.au/
> Signed-off-by: Bagas Sanjaya <bagasdotme@...il.com>

Oof, thanks for fixing that for me.
Reviewed-by: "Darrick J. Wong" <djwong@...nel.org>

--D

> ---
>  Documentation/admin-guide/xfs.rst | 18 +++++++++---------
>  1 file changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/Documentation/admin-guide/xfs.rst b/Documentation/admin-guide/xfs.rst
> index d6f531f2c0e694..c85cd327af284d 100644
> --- a/Documentation/admin-guide/xfs.rst
> +++ b/Documentation/admin-guide/xfs.rst
> @@ -355,15 +355,15 @@ None currently.
>  Removed Sysctls
>  ===============
>  
> -=============================	=======
> -  Name				Removed
> -=============================	=======
> -  fs.xfs.xfsbufd_centisec	v4.0
> -  fs.xfs.age_buffer_centisecs	v4.0
> -  fs.xfs.irix_symlink_mode      v6.18
> -  fs.xfs.irix_sgid_inherit      v6.18
> -  fs.xfs.speculative_cow_prealloc_lifetime      v6.18
> -=============================	=======
> +==========================================   =======
> +  Name                                       Removed
> +==========================================   =======
> +  fs.xfs.xfsbufd_centisec                    v4.0
> +  fs.xfs.age_buffer_centisecs                v4.0
> +  fs.xfs.irix_symlink_mode                   v6.18
> +  fs.xfs.irix_sgid_inherit                   v6.18
> +  fs.xfs.speculative_cow_prealloc_lifetime   v6.18
> +==========================================   =======
>  
>  Error handling
>  ==============
> 
> base-commit: e90dcba0a350836a5e1a1ac0f65f9e74644d7d3b
> -- 
> An old man doll... just what I always wanted! - Clara
>