linux-kernel - Re: [PATCH] ACPI: SPCR: Support Precise Baud Rate filed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250913070625.16332-1-cp0613@linux.alibaba.com>
Date: Sat, 13 Sep 2025 15:06:25 +0800
From: cp0613@...ux.alibaba.com
To: guoren@...nel.org
Cc: cp0613@...ux.alibaba.com,
	jeeheng.sia@...rfivetech.com,
	lenb@...nel.org,
	linux-acpi@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	rafael@...nel.org
Subject: Re: [PATCH] ACPI: SPCR: Support Precise Baud Rate filed

On Sat, 13 Sep 2025 13:24:21 +0800, guoren@...nel.org wrote:

> > It contains a specific non-zero baud rate which overrides the value
> > of the Configured Baud Rate field. If this field is zero or not
> The spec states that it would "override" the baud rate. That means it
> should happen behind the table->baud_rate or firmware still needs to
> give out a legal Configured Baud Rate for precise_baudrate.> 

> Then, we move these:
> +       if (table->precise_baudrate)
> +               baud_rate = table->precise_baudrate;
> behind the "switch (table->baud_rate) {}".> 

> Right?> 

> > present, Configured Baud Rate is used.

OK, I think "override" means priority in a sense, there is no need to do
an overriding action in the behavior.