linux-kernel - Re: [PATCH] firewire: core: remove useless lockdep_assert

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250913105123.GA777602@workstation.local>
Date: Sat, 13 Sep 2025 19:51:23 +0900
From: Takashi Sakamoto <o-takashi@...amocchi.jp>
To: linux1394-devel@...ts.sourceforge.net
Cc: linux-kernel@...r.kernel.org
Subject: Re: [PATCH] firewire: core: remove useless lockdep_assert_held()

On Fri, Sep 12, 2025 at 07:13:11AM +0900, Takashi Sakamoto wrote:
> The bm_work work item should be scheduled after holding fw_card reference
> counting. At a commit 25feb1a96e21 ("firewire: core: use cleanup function
> in bm_work"), I misinterpreted it as fw_card spinlock and inserted
> lockdep_assert_hold() wrongly.
> 
> This commit removes the useless line.
> 
> Fixes: 25feb1a96e21 ("firewire: core: use cleanup function in bm_work")
> Signed-off-by: Takashi Sakamoto <o-takashi@...amocchi.jp>
> ---
>  drivers/firewire/core-card.c | 2 --
>  1 file changed, 2 deletions(-)

Applied to for-next branch.


Regards

Takashi Sakamoto