linux-kernel - Re: [PATCH 2/3] arm64: dts: allwinner: t527: avaota-a1: hook up external 32k crystal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4676490.LvFx2qVVIh@jernej-laptop>
Date: Sat, 13 Sep 2025 13:31:09 +0200
From: Jernej Škrabec <jernej.skrabec@...il.com>
To: Chen-Yu Tsai <wens@...e.org>, Jernej Skrabec <jernej@...nel.org>,
 Samuel Holland <samuel@...lland.org>,
 Andre Przywara <andre.przywara@....com>, Chen-Yu Tsai <wens@...nel.org>
Cc: linux-sunxi@...ts.linux.dev, devicetree@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject:
 Re: [PATCH 2/3] arm64: dts: allwinner: t527: avaota-a1: hook up external 32k
 crystal

Dne sobota, 13. september 2025 ob 12:24:49 Srednjeevropski poletni čas je Chen-Yu Tsai napisal(a):
> From: Chen-Yu Tsai <wens@...e.org>
> 
> When the board was added, its external 32.768 KHz crystal was described
> but not hooked up correctly. This meant the device had to fall back to
> the SoC's internal oscillator or divide a 32 KHz clock from the main
> oscillator, neither of which are accurate for the RTC. As a result the
> RTC clock will drift badly.
> 
> Hook the crystal up to the RTC block and request the correct clock rate.
> 
> Fixes: dbe54efa32af ("arm64: dts: allwinner: a523: add Avaota-A1 router support")
> Signed-off-by: Chen-Yu Tsai <wens@...e.org>

Acked-by: Jernej Skrabec <jernej.skrabec@...il.com>

Best regards,
Jernej

> ---
>  arch/arm64/boot/dts/allwinner/sun55i-t527-avaota-a1.dts | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/allwinner/sun55i-t527-avaota-a1.dts b/arch/arm64/boot/dts/allwinner/sun55i-t527-avaota-a1.dts
> index 535387912d9b..054d0357c139 100644
> --- a/arch/arm64/boot/dts/allwinner/sun55i-t527-avaota-a1.dts
> +++ b/arch/arm64/boot/dts/allwinner/sun55i-t527-avaota-a1.dts
> @@ -354,6 +354,14 @@ &r_pio {
>  	vcc-pm-supply = <&reg_aldo3>;
>  };
>  
> +&rtc {
> +	clocks = <&r_ccu CLK_BUS_R_RTC>, <&osc24M>,
> +		 <&r_ccu CLK_R_AHB>, <&ext_osc32k>;
> +	clock-names = "bus", "hosc", "ahb", "ext-osc32k";
> +	assigned-clocks = <&rtc CLK_OSC32K>;
> +	assigned-clock-rates = <32768>;
> +};
> +
>  &uart0 {
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&uart0_pb_pins>;
>