linux-kernel - Re: [PATCH] media: v4l2-ctrls: add full AV1 profile validation in validate_av1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKPKb89KkEz6nitJk6sX59J=AX1FaG4jA2EBXfRLdGHms8ER4w@mail.gmail.com>
Date: Sat, 13 Sep 2025 17:52:16 +0530
From: opensource india <opensource206@...il.com>
To: Nicolas Dufresne <nicolas.dufresne@...labora.com>
Cc: mchehab@...nel.org, hverkuil@...nel.org, ribalda@...omium.org, 
	laurent.pinchart@...asonboard.com, yunkec@...gle.com, 
	sakari.ailus@...ux.intel.com, james.cowgill@...ize.com, 
	linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] media: v4l2-ctrls: add full AV1 profile validation in validate_av1_sequence()

On Fri, Sep 12, 2025 at 9:07 PM Nicolas Dufresne
<nicolas.dufresne@...labora.com> wrote:

> The changes looks good and seems safer. I will have to run some tests to make
> sure we don't regress anything. About your commit message, there is a push to
> make things more imperative, so that would mean reformatting to the following
> and dropping the first paragraph:
>
>    Complete the "TODO: PROFILES" by enforcing all profile-specific constraints
>    as defined by the AV1 specification (Section 5.5.2, "Color config syntax"):
>
>    - Profile 0: 8/10-bit only, 4:2:0 subsampling, no monochrome
>    - Profile 1: 8/10-bit only, 4:4:4 only, no monochrome
>    - Profile 2: 8/10/12-bit, 4:2:0 / 4:2:2 / 4:4:4 allowed, monochrome allowed
>
>    Additionally, when the MONO_CHROME flag is set:
>    - subsampling_x and subsampling_y must both be 1
>    - separate_uv_delta_q must be 0
>
>    These checks prevent userspace from providing invalid AV1 sequence
>    headers that would otherwise be accepted, leading to undefined
>    driver or hardware behavior.
>
> If you are fine with this change I can apply. Otherwise please include my Rb in
> your v2.
>
> Reviewed-by: Nicolas Dufresne <nicolas.dufresne@...labora.com>

Thank you for your feedback. I’ve added some more changes and sent
patch v3 in this series.
Could you please review it?

Regards,
Pavan Bobba