linux-kernel - Re: [PATCH] initrd: Remove unnecessary goto label 'successful

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <41D6E945-CB4B-4AE4-9ED7-277B59E9DC32@linux.dev>
Date: Sat, 13 Sep 2025 15:30:15 +0200
From: Thorsten Blum <thorsten.blum@...ux.dev>
To: Klara Modin <klarasmodin@...il.com>
Cc: Alexander Viro <viro@...iv.linux.org.uk>,
 Christian Brauner <brauner@...nel.org>,
 Jan Kara <jack@...e.cz>,
 linux-fsdevel@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] initrd: Remove unnecessary goto label 'successful_load'

On 13. Sep 2025, at 15:11, Klara Modin wrote:
> On 2025-09-13 14:15:14 +0200, Thorsten Blum wrote:
>> The goto label 'successful_load' isn't really necessary. Set 'res = 1'
>> immediately and let 'goto done' handle the rest.
>> 
>> No functional changes.
>> 
>> Signed-off-by: Thorsten Blum <thorsten.blum@...ux.dev>
>> ---
>> ...
> 
> This is now the only place where res will be set to 1.

Sorry my bad.

> This does not seem correct? After this patch res is not updated to 1 anymore
> if execution reaches here without taking another goto, i.e. the return
> value is changed by this patch.

Thanks, I agree that it doesn't make sense. I only intended to delete
the label, not the 'res = 1'.

Please ignore this patch (unless someone thinks removing the goto label
is worth a v2) and sorry for the noise.

Thanks,
Thorsten