linux-kernel - Re: [PATCH v2 3/6] iio: adc: ad7124: use guard(mutex) to simplify return paths

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250913144012.0e6befcb@jic23-huawei>
Date: Sat, 13 Sep 2025 14:40:12 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Andy Shevchenko <andriy.shevchenko@...el.com>
Cc: David Lechner <dlechner@...libre.com>, Andy Shevchenko
 <andy.shevchenko@...il.com>, Michael Hennerich
 <Michael.Hennerich@...log.com>, Nuno Sá <nuno.sa@...log.com>,
 Andy Shevchenko <andy@...nel.org>, linux-iio@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 3/6] iio: adc: ad7124: use guard(mutex) to simplify
 return paths

On Fri, 12 Sep 2025 21:07:58 +0300
Andy Shevchenko <andriy.shevchenko@...el.com> wrote:

> On Fri, Sep 12, 2025 at 12:41:08PM -0500, David Lechner wrote:
> > On 9/12/25 12:15 PM, Andy Shevchenko wrote:  
> > > On Fri, Sep 12, 2025 at 09:19:36AM -0500, David Lechner wrote:  
> > >> On 9/11/25 11:39 PM, Andy Shevchenko wrote:  
> > >>> On Fri, Sep 12, 2025 at 12:42 AM David Lechner <dlechner@...libre.com> wrote:  
> > >>>>
> > >>>> Use guard(mutex) in a couple of functions to allow direct returns. This
> > >>>> simplifies the code a bit and will make later changes easier.  
> > >>>
> > >>> From this and the patch it's unclear if cleanup.h was already there or
> > >>> not. If not, this patch misses it, if yes, the commit message should
> > >>> be different.  
> > >>
> > >> cleanup.h is already there. I'm not sure what would need to be different
> > >> in the commit message though.  
> > > 
> > > I expect something like "finish converting the driver to use guard()()..."  
> > 
> > cleanup.h was previously included for __free(), so the guard() stuff
> > is all new.  
> 
> Okay, then something like "Cover the lock handling using guard()()..."
> The point I'm trying to make is that "Use $FOO API/etc" without new header
> being included either:
> 1) missing inclusion (proxying);
> 2) start using of a new API from the library/header that we already use for
> another API, but without mentioning that.
> 
I went with the far from subtle solution of adding a line to the commit log
that says

cleanup.h is already included for prior use of __free()

Seemed like that would be enough for Andy's request and so I added
his tag (as given to the cover letter).

Jonathan