linux-kernel - Re: [PATCH liburing v1] barrier: Convert C++ barrier functions into macros

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e0559c10-104d-4da8-9f7f-d2ffd73d8df3@acm.org>
Date: Sat, 13 Sep 2025 07:40:17 -0700
From: Bart Van Assche <bvanassche@....org>
To: Ammar Faizi <ammarfaizi2@...weeb.org>, Jens Axboe <axboe@...nel.dk>
Cc: Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
 io-uring Mailing List <io-uring@...r.kernel.org>, dr.xiaosa@...il.com,
 Alviro Iskandar Setiawan <alviro.iskandar@...weeb.org>
Subject: Re: [PATCH liburing v1] barrier: Convert C++ barrier functions into
 macros

On 9/13/25 6:15 AM, Ammar Faizi wrote:
> Convert them into macros just like the C version to fix it.

Converting functions into macros is a step backwards. Please check
whether removing the "static" keyword from the inline function 
definitions in header files is sufficient to suppress the compiler
warning about TU-local definitions.

Thanks,

Bart.