linux-kernel - Re: [PATCH v1] perf lock: Provide a host

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aMS_VJpwvwBIW44t@google.com>
Date: Fri, 12 Sep 2025 17:48:20 -0700
From: Namhyung Kim <namhyung@...nel.org>
To: Ian Rogers <irogers@...gle.com>
Cc: Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>,
	Arnaldo Carvalho de Melo <acme@...nel.org>,
	Mark Rutland <mark.rutland@....com>,
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
	Jiri Olsa <jolsa@...nel.org>,
	Adrian Hunter <adrian.hunter@...el.com>,
	Kan Liang <kan.liang@...ux.intel.com>,
	linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] perf lock: Provide a host_env for session new

On Fri, Sep 12, 2025 at 05:01:29PM -0700, Ian Rogers wrote:
> When "perf lock con" is run in a live mode, with no data file, a host
> environment must be provided. Testing missed this as a failing assert
> was creating the 1 line of expected stderr output.
> 
> Signed-off-by: Ian Rogers <irogers@...gle.com>
> ---
> Please consider this patch for v6.17 fixes.

Yep, I'll queue it to perf-tools tree.

Thanks,
Namhyung

> ---
>  tools/perf/builtin-lock.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/perf/builtin-lock.c b/tools/perf/builtin-lock.c
> index fd49703021fd..078634461df2 100644
> --- a/tools/perf/builtin-lock.c
> +++ b/tools/perf/builtin-lock.c
> @@ -2009,6 +2009,7 @@ static int __cmd_contention(int argc, const char **argv)
>  		.owner = show_lock_owner,
>  		.cgroups = RB_ROOT,
>  	};
> +	struct perf_env host_env;
>  
>  	lockhash_table = calloc(LOCKHASH_SIZE, sizeof(*lockhash_table));
>  	if (!lockhash_table)
> @@ -2024,7 +2025,10 @@ static int __cmd_contention(int argc, const char **argv)
>  	eops.mmap		 = perf_event__process_mmap;
>  	eops.tracing_data	 = perf_event__process_tracing_data;
>  
> -	session = perf_session__new(use_bpf ? NULL : &data, &eops);
> +	perf_env__init(&host_env);
> +	session = __perf_session__new(use_bpf ? NULL : &data, &eops,
> +				/*trace_event_repipe=*/false, &host_env);
> +
>  	if (IS_ERR(session)) {
>  		pr_err("Initializing perf session failed\n");
>  		err = PTR_ERR(session);
> @@ -2142,6 +2146,7 @@ static int __cmd_contention(int argc, const char **argv)
>  	evlist__delete(con.evlist);
>  	lock_contention_finish(&con);
>  	perf_session__delete(session);
> +	perf_env__exit(&host_env);
>  	zfree(&lockhash_table);
>  	return err;
>  }
> -- 
> 2.51.0.384.g4c02a37b29-goog
>