linux-kernel - [PATCH v2] acpi,srat: Fix incorrect device handle check for Generic Initiator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20250913023224.39281-1-xueshuai@linux.alibaba.com>
Date: Sat, 13 Sep 2025 10:32:24 +0800
From: Shuai Xue <xueshuai@...ux.alibaba.com>
To: rafael@...nel.org,
	lenb@...nel.org,
	robert.moore@...el.com
Cc: andrew@...nel.org,
	bfaccini@...dia.com,
	eahariha@...ux.microsoft.com,
	dan.j.williams@...el.com,
	thorsten.blum@...ux.dev,
	gourry@...rry.net,
	xueshuai@...ux.alibaba.com,
	nunodasneves@...ux.microsoft.com,
	wangyuquan1236@...tium.com.cn,
	Jonathan.Cameron@...wei.com,
	linux-acpi@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	acpica-devel@...ts.linux.dev
Subject: [PATCH v2] acpi,srat: Fix incorrect device handle check for Generic Initiator

The Generic Initiator Affinity Structure in SRAT table uses device
handle type field to indicate the device type. According to ACPI
specification, the device handle type value of 1 represents PCI device,
not 0.

Fixes: 894c26a1c274 ("ACPI: Support Generic Initiator only domains")
Reported-by: Wu Zongyong <wuzongyong@...ux.alibaba.com>
Signed-off-by: Shuai Xue <xueshuai@...ux.alibaba.com>
---
changes since v1: drop changes in actbl3.h to make it easy to progress per Jonathan
---
 drivers/acpi/numa/srat.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/acpi/numa/srat.c b/drivers/acpi/numa/srat.c
index 53816dfab645..aa87ee1583a4 100644
--- a/drivers/acpi/numa/srat.c
+++ b/drivers/acpi/numa/srat.c
@@ -237,7 +237,7 @@ acpi_table_print_srat_entry(struct acpi_subtable_header *header)
 		struct acpi_srat_generic_affinity *p =
 			(struct acpi_srat_generic_affinity *)header;
 
-		if (p->device_handle_type == 0) {
+		if (p->device_handle_type == 1) {
 			/*
 			 * For pci devices this may be the only place they
 			 * are assigned a proximity domain
-- 
2.39.3