| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <a079375f-38c2-4f38-b2be-57737084fde8@kernel.org> Date: Sun, 14 Sep 2025 12:06:24 +0200 From: Krzysztof Kozlowski <krzk@...nel.org> To: Askar Safin <safinaskar@...il.com>, linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org Cc: Linus Torvalds <torvalds@...ux-foundation.org>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Christian Brauner <brauner@...nel.org>, Al Viro <viro@...iv.linux.org.uk>, Jan Kara <jack@...e.cz>, Christoph Hellwig <hch@....de>, Jens Axboe <axboe@...nel.dk>, Andy Shevchenko <andy.shevchenko@...il.com>, Aleksa Sarai <cyphar@...har.com>, Thomas Weißschuh <thomas.weissschuh@...utronix.de>, Julian Stecklina <julian.stecklina@...erus-technology.de>, Gao Xiang <hsiangkao@...ux.alibaba.com>, Art Nikpal <email2tema@...il.com>, Andrew Morton <akpm@...ux-foundation.org>, Eric Curtin <ecurtin@...hat.com>, Alexander Graf <graf@...zon.com>, Rob Landley <rob@...dley.net>, Lennart Poettering <mzxreary@...inter.de>, linux-arch@...r.kernel.org, linux-alpha@...r.kernel.org, linux-snps-arc@...ts.infradead.org, linux-arm-kernel@...ts.infradead.org, linux-csky@...r.kernel.org, linux-hexagon@...r.kernel.org, loongarch@...ts.linux.dev, linux-m68k@...ts.linux-m68k.org, linux-mips@...r.kernel.org, linux-openrisc@...r.kernel.org, linux-parisc@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org, linux-riscv@...ts.infradead.org, linux-s390@...r.kernel.org, linux-sh@...r.kernel.org, sparclinux@...r.kernel.org, linux-um@...ts.infradead.org, x86@...nel.org, Ingo Molnar <mingo@...hat.com>, linux-block@...r.kernel.org, initramfs@...r.kernel.org, linux-api@...r.kernel.org, linux-doc@...r.kernel.org, linux-efi@...r.kernel.org, linux-ext4@...r.kernel.org, "Theodore Y . Ts'o" <tytso@....edu>, linux-acpi@...r.kernel.org, Michal Simek <monstr@...str.eu>, devicetree@...r.kernel.org, Luis Chamberlain <mcgrof@...nel.org>, Kees Cook <kees@...nel.org>, Thorsten Blum <thorsten.blum@...ux.dev>, Heiko Carstens <hca@...ux.ibm.com>, patches@...ts.linux.dev Subject: Re: [PATCH RESEND 21/62] init: remove all mentions of root=/dev/ram* On 13/09/2025 02:38, Askar Safin wrote: > Initrd support is removed, so root=/dev/ram* is never correct For all your other patches (here is correct): Please wrap commit message according to Linux coding style / submission process (neither too early nor over the limit): https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597 > > Signed-off-by: Askar Safin <safinaskar@...il.com> > --- > Documentation/admin-guide/kernel-parameters.txt | 3 +-- > Documentation/arch/m68k/kernel-options.rst | 9 ++------- > arch/arm/boot/dts/arm/integratorap.dts | 2 +- > arch/arm/boot/dts/arm/integratorcp.dts | 2 +- > arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-cmm.dts | 2 +- > .../boot/dts/aspeed/aspeed-bmc-facebook-galaxy100.dts | 2 +- > .../arm/boot/dts/aspeed/aspeed-bmc-facebook-minipack.dts | 2 +- > .../arm/boot/dts/aspeed/aspeed-bmc-facebook-wedge100.dts | 2 +- > arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-wedge40.dts | 2 +- > arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yamp.dts | 2 +- > .../boot/dts/aspeed/ast2600-facebook-netbmc-common.dtsi | 2 +- No, don't do that. DTS is always separate. Don't mix DTS into such huge patchbom, either. > arch/arm/boot/dts/hisilicon/hi3620-hi4511.dts | 2 +- > .../boot/dts/intel/ixp/intel-ixp42x-welltech-epbx100.dts | 2 +- > arch/arm/boot/dts/nspire/nspire-classic.dtsi | 2 +- > arch/arm/boot/dts/nspire/nspire-cx.dts | 2 +- > arch/arm/boot/dts/samsung/exynos4210-origen.dts | 2 +- > arch/arm/boot/dts/samsung/exynos4210-smdkv310.dts | 2 +- > arch/arm/boot/dts/samsung/exynos4412-smdk4412.dts | 2 +- > arch/arm/boot/dts/samsung/exynos5250-smdk5250.dts | 2 +- > arch/arm/boot/dts/st/ste-nomadik-nhk15.dts | 2 +- > arch/arm/boot/dts/st/ste-nomadik-s8815.dts | 2 +- > arch/arm/boot/dts/st/stm32429i-eval.dts | 2 +- > arch/arm/boot/dts/st/stm32746g-eval.dts | 2 +- > arch/arm/boot/dts/st/stm32f429-disco.dts | 2 +- > arch/arm/boot/dts/st/stm32f469-disco.dts | 2 +- > arch/arm/boot/dts/st/stm32f746-disco.dts | 2 +- > arch/arm/boot/dts/st/stm32f769-disco.dts | 2 +- > arch/arm/boot/dts/st/stm32h743i-disco.dts | 2 +- > arch/arm/boot/dts/st/stm32h743i-eval.dts | 2 +- > arch/arm/boot/dts/st/stm32h747i-disco.dts | 2 +- > arch/arm/boot/dts/st/stm32h750i-art-pi.dts | 2 +- > arch/arm/configs/assabet_defconfig | 2 +- > arch/arm/configs/at91_dt_defconfig | 2 +- > arch/arm/configs/exynos_defconfig | 2 +- To me your patchset is way too big bomb, too difficult to review. You touch too many subsystems in the same commits. In few cases I saw dependency, in other cases like here - there is no dependency! So why grouping independent things together? It only makes it difficult to review. Anyway, combining here DTS is a no-go for me. Best regards, Krzysztof
Powered by blists - more mailing lists