linux-kernel - Re: [PATCH 3/4] pcie: s32g: Add initial PCIe support (RC)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c3449621-546d-4911-9692-a465c6fa9697@kernel.org>
Date: Sun, 14 Sep 2025 12:15:12 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Vincent Guittot <vincent.guittot@...aro.org>, chester62515@...il.com,
 mbrugger@...e.com, ghennadi.procopciuc@....nxp.com, s32@....com,
 lpieralisi@...nel.org, kwilczynski@...nel.org, mani@...nel.org,
 robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
 Ionut.Vicovan@....com, larisa.grigore@....com, Ghennadi.Procopciuc@....com,
 ciprianmarian.costea@....com, bogdan.hamciuc@....com,
 linux-arm-kernel@...ts.infradead.org, linux-pci@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/4] pcie: s32g: Add initial PCIe support (RC)

On 12/09/2025 16:14, Vincent Guittot wrote:
> +
> +static u64 s32g_get_coherency_boundary(struct device *dev)
> +{
> +	struct device_node *np;
> +	struct resource res;
> +
> +	np = of_find_node_by_type(NULL, "memory");

You leak OF node.

> +
> +	if (of_address_to_resource(np, 0, &res)) {
> +		dev_warn(dev, "Fail to get coherency boundary\n");
> +		return 0;
> +	}
> +
> +	return res.start;
> +}



...


> +
> +static struct platform_driver s32g_pcie_driver = {
> +	.driver = {
> +		.name	= "s32g-pcie",
> +		.owner	= THIS_MODULE,

That 12-yo code. My litmus test from last talk...

Please clean it up from such old coding style. BTW, tools are reporting
this since years (in this case coccinelle), so be sure that you actually
run standard static checks on new driver code (smatch, sparse, coccinelle).


Best regards,
Krzysztof